Bug 232396

Summary: Disable NETSCAPE_PLUGIN_API at build time on macOS and Windows
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, benjamin, cdumez, cmarcelo, darin, ews-watchlist, ggaren, mkwst
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch ggaren: review+

Alex Christensen
Reported 2021-10-27 12:24:08 PDT
Disable NETSCAPE_PLUGIN_API at build time on macOS
Attachments
Patch (22.67 KB, patch)
2021-10-27 12:34 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (34.34 KB, patch)
2021-10-27 16:45 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (43.85 KB, patch)
2021-10-27 19:22 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (46.93 KB, patch)
2021-10-27 21:28 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (47.12 KB, patch)
2021-10-27 22:19 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (46.96 KB, patch)
2021-10-28 08:41 PDT, Alex Christensen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (46.17 KB, patch)
2021-10-28 11:02 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (51.95 KB, patch)
2021-10-28 13:06 PDT, Alex Christensen 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-10-27 12:34:28 PDT
Created attachment 442622 [details] Patch
Darin Adler
Comment 2 2021-10-27 14:58:20 PDT
Comment on attachment 442622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442622&action=review Looks like there are 10 tests where we have to change expected results or skip or remove the tests. > Source/WTF/ChangeLog:3 > + Disable NETSCAPE_PLUGIN_API at build time on macOS Is it enabled for any other platform, or is this the last one with it on?
Alex Christensen
Comment 3 2021-10-27 16:45:59 PDT
Created attachment 442651 [details] Patch
Alex Christensen
Comment 4 2021-10-27 17:34:32 PDT
Supported was removed on Linux in https://bugs.webkit.org/show_bug.cgi?id=215503 NPAPI worked on Windows WebKitLegacy last I checked but I am under the impression that that was just for Safari on Windows. I am under the impression that it is no longer used for anything. It was never made to work for M1 Macs. It was never made to work for WebKit2 on Windows.
Alex Christensen
Comment 5 2021-10-27 19:22:09 PDT
Created attachment 442663 [details] Patch
Alex Christensen
Comment 6 2021-10-27 19:57:34 PDT
Comment on attachment 442663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442663&action=review > LayoutTests/fast/replaced/pdf-as-embed-with-no-mime-type-is-not-blank.html:-1 > -<!-- webkit-test-runner [ PluginsEnabled=false ] --> This should load fine. It looks like some embed loading code is behind NETSCAPE_PLUGIN_API that shouldn't be.
Alex Christensen
Comment 7 2021-10-27 21:28:19 PDT
Created attachment 442671 [details] Patch
Alex Christensen
Comment 8 2021-10-27 22:19:30 PDT
Created attachment 442675 [details] Patch
Alex Christensen
Comment 9 2021-10-28 08:41:19 PDT
Created attachment 442708 [details] Patch
Darin Adler
Comment 10 2021-10-28 09:14:48 PDT
(In reply to Alex Christensen from comment #4) > NPAPI worked on Windows WebKitLegacy last I checked Can we turn that off?
Alex Christensen
Comment 11 2021-10-28 11:02:41 PDT
Created attachment 442721 [details] Patch
Alex Christensen
Comment 12 2021-10-28 13:02:59 PDT
This turns off NPAPI on Windows WebKitLegacy, too.
Alex Christensen
Comment 13 2021-10-28 13:06:36 PDT
Created attachment 442732 [details] Patch
Geoffrey Garen
Comment 14 2021-10-28 13:10:37 PDT
Comment on attachment 442732 [details] Patch r=me
Alex Christensen
Comment 15 2021-10-28 14:21:56 PDT
r285003
Adam Roben (:aroben)
Comment 16 2021-10-30 09:34:42 PDT
(In reply to Alex Christensen from comment #4) > It was never made to work for WebKit2 on Windows. I beg to differ! For example, https://bugs.webkit.org/show_bug.cgi?id=60210 It’s nice to see this all go though.
Alex Christensen
Comment 17 2021-10-30 10:44:09 PDT
Well there's a blast from the past! I take that back. It wasn't implemented for WebKit2 Windows in recent trunk, but it had been implemented many years ago then removed many years ago.
EWS
Comment 18 2024-09-13 09:35:49 PDT
Committed 283628@main (2c7e94c004c1): <https://commits.webkit.org/283628@main> Reviewed commits have been landed. Closing PR #33502 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.