Summary: | Fail build with -DENABLE_WEB_AUDIO=OFF -DENABLE_VIDEO=OFF in webkit2gtk 2.34.1 (gtk3) | ||
---|---|---|---|
Product: | WebKit | Reporter: | sL1pKn07 <sl1pkn07> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Blocker | CC: | alex_y_xu, aperez, mcatanzaro |
Priority: | P2 | ||
Version: | Other | ||
Hardware: | PC | ||
OS: | Linux |
Description
sL1pKn07
2021-10-27 11:44:10 PDT
applying this patch on 2.34.1 resolved the issue for me: diff -ru webkitgtk-2.34.1/Source/WebCore/accessibility/AXObjectCache.cpp b/Source/WebCore/accessibility/AXObjectCache.cpp --- webkitgtk-2.34.1/Source/WebCore/accessibility/AXObjectCache.cpp 2021-09-02 02:33:26.000000000 -0400 +++ b/Source/WebCore/accessibility/AXObjectCache.cpp 2021-11-14 11:52:02.335845108 -0500 @@ -528,9 +528,11 @@ || (is<HTMLImageElement>(node) && downcast<HTMLImageElement>(node)->hasAttributeWithoutSynchronization(usemapAttr))) return false; +#if ENABLE(VIDEO) // Exclude video and audio elements. if (is<HTMLMediaElement>(node)) return false; +#endif return true; } diff -ru webkitgtk-2.34.1/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp --- webkitgtk-2.34.1/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp 2021-09-01 05:16:50.000000000 -0400 +++ b/Source/WebCore/platform/graphics/BifurcatedGraphicsContext.cpp 2021-11-14 12:10:00.801054150 -0500 @@ -269,11 +269,13 @@ m_secondaryContext.drawPattern(nativeImage, imageSize, destRect, tileRect, patternTransform, phase, spacing, options); } +#if ENABLE(VIDEO) void BifurcatedGraphicsContext::paintFrameForMedia(MediaPlayer& player, const FloatRect& destination) { m_primaryContext.paintFrameForMedia(player, destination); m_secondaryContext.paintFrameForMedia(player, destination); } +#endif void BifurcatedGraphicsContext::scale(const FloatSize& scale) { thansk for the patch works correct greetiungs! duplicate of bug 232264 fails again in 2.34.3 [ 38%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-38.cpp.o In file included from /usr/include/X11/Xlib.h:44, from /usr/include/X11/Xutil.h:53, from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/graphics/x11/XUniquePtr.h:31, from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/graphics/glx/GLContextGLX.h:25, from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:20, from /tmp/makepkg/webkit2gtk/src/build/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-38.cpp:1: /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:84:5: error: expected identifier before numeric constant 84 | None, | ^~~~ /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:84:5: error: expected '}' before numeric constant In file included from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:30, from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/graphics/gtk/DisplayRefreshMonitorGtk.h:30, from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp:27, from /tmp/makepkg/webkit2gtk/src/build/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-38.cpp:4: /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:83:39: note: to match this '{' 83 | enum class DynamicRangeMode : uint8_t { | ^ In file included from /usr/include/X11/Xlib.h:44, from /usr/include/X11/Xutil.h:53, from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/graphics/x11/XUniquePtr.h:31, from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/graphics/glx/GLContextGLX.h:25, from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/graphics/glx/GLContextGLX.cpp:20, from /tmp/makepkg/webkit2gtk/src/build/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-38.cpp:1: /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:84:5: error: expected unqualified-id before numeric constant 84 | None, | ^~~~ In file included from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h:30, from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/graphics/gtk/DisplayRefreshMonitorGtk.h:30, from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/graphics/gtk/DisplayRefreshMonitorGtk.cpp:27, from /tmp/makepkg/webkit2gtk/src/build/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-38.cpp:4: /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:93:11: error: 'DynamicRangeMode' does not name a type 93 | constexpr DynamicRangeMode preferredDynamicRangeMode(Widget* = nullptr) { return DynamicRangeMode::Standard; } | ^~~~~~~~~~~~~~~~ /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:99:47: error: 'Widget' was not declared in this scope; did you mean 'WebCore::Widget'? 99 | constexpr bool screenSupportsHighDynamicRange(Widget* = nullptr) { return false; } | ^~~~~~ | WebCore::Widget /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:56:7: note: 'WebCore::Widget' declared here 56 | class Widget; | ^~~~~~ /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:99:55: error: expected primary-expression before '=' token 99 | constexpr bool screenSupportsHighDynamicRange(Widget* = nullptr) { return false; } | ^ /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:108:30: error: 'PlatformDisplayID' was not declared in this scope; did you mean 'WebCore::PlatformDisplayID'? 108 | const ScreenData* screenData(PlatformDisplayID screendisplayID); | ^~~~~~~~~~~~~~~~~ | WebCore::PlatformDisplayID /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:58:7: note: 'WebCore::PlatformDisplayID' declared here 58 | using PlatformDisplayID = uint32_t; | ^~~~~~~~~~~~~~~~~ /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:109:16: error: 'PlatformDisplayID' does not name a type; did you mean 'PlatformDisplay_h'? 109 | WEBCORE_EXPORT PlatformDisplayID primaryScreenDisplayID(); | ^~~~~~~~~~~~~~~~~ | PlatformDisplay_h /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:161:1: error: expected declaration before '}' token 161 | } // namespace WebCore | ^ /tmp/makepkg/webkit2gtk/src/webkitgtk-2.34.3/Source/WebCore/platform/PlatformScreen.h:173:5: error: template argument 2 is invalid 173 | >; | ^ make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/build.make:9735: Source/WebCore/CMakeFiles/WebCore.dir/__/__/WebCore/DerivedSources/unified-sources/UnifiedSource-3c72abbe-38.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:1149: Is this still broken? (In reply to Michael Catanzaro from comment #5) > Is this still broken? let me check (my last build is 2.34.5, now build process for 2.36.2) IIRC, we made sure that this combination of options builds okay in the 2.36.x releases, even if in theory disabling the multimedia support is not something we officially support. I have just completed a build of 2.38.5 with -DENABLE_WEB_AUDIO=OFF and -DENABLE_VIDEO=OFF and it succeeded, so it seems things are still good on this front. same issue in 2.44.0 [ 39%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/FormatConverter.cpp.o In file included from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.44.0/Source/WebCore/platform/graphics/FormatConverter.h:32, from /tmp/makepkg/webkit2gtk/src/webkitgtk-2.44.0/Source/WebCore/platform/graphics/FormatConverter.cpp:32: /tmp/makepkg/webkit2gtk/src/webkitgtk-2.44.0/Source/WebCore/platform/graphics/GraphicsContextGL.h:1619:20: error: 'VideoFrame' was not declared in this scope 1619 | virtual RefPtr<VideoFrame> surfaceBufferToVideoFrame(SurfaceBuffer) = 0; | ^~~~~~~~~~ /tmp/makepkg/webkit2gtk/src/webkitgtk-2.44.0/Source/WebCore/platform/graphics/GraphicsContextGL.h:1619:30: error: template argument 1 is invalid 1619 | virtual RefPtr<VideoFrame> surfaceBufferToVideoFrame(SurfaceBuffer) = 0; | ^ /tmp/makepkg/webkit2gtk/src/webkitgtk-2.44.0/Source/WebCore/platform/graphics/GraphicsContextGL.h:1619:30: error: template argument 2 is invalid /tmp/makepkg/webkit2gtk/src/webkitgtk-2.44.0/Source/WebCore/platform/graphics/GraphicsContextGL.h:1619:30: error: template argument 3 is invalid make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/build.make:1159: Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/FormatConverter.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:1370: Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2 make: *** [Makefile:156: all] Error 2 co'mon... greetings (In reply to sL1pKn07 from comment #8) > co'mon... Pull requests are welcome. Generally nobody is going to fix build failures for you. I'm going to go ahead and close this bug again because the build failure you posted doesn't look at all similar to the one reported here. That's surely a completely different problem. is the same problem: Fail build with -DENABLE_WEB_AUDIO=OFF -DENABLE_VIDEO=OFF the output can be different. but the trigger is the same greetings Report a new bug. Don't reopen this one. The build with -DENABLE_VIDEO=OFF breaks every few weeks; if you try to use one bug report for every failure, it's going to quickly become 500 comments long. and become 500 new bugs in the buglist, if you prefeer that, ok. i'm go ahead greetings |