Bug 232360

Summary: [WebKit] Enable -Wformat=2 warnings
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebKit2Assignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, darin, ews-watchlist, hi, joepeck, kkinnunen, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1
darin: review+
Patch for landing none

David Kilzer (:ddkilzer)
Reported 2021-10-26 19:31:30 PDT
Enable -Wformat=2 warnings in the WebKit project. This includes -Wformat-nonliteral among other warnings. <rdar://problem/84571460>
Attachments
Patch v1 (19.75 KB, patch)
2021-10-26 19:50 PDT, David Kilzer (:ddkilzer) 		darin: review+
DetailsFormatted DiffDiff
Patch for landing (20.26 KB, patch)
2021-10-27 18:01 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2021-10-26 19:50:09 PDT
Created attachment 442559 [details] Patch v1
Darin Adler
Comment 2 2021-10-27 16:02:03 PDT
Comment on attachment 442559 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=442559&action=review > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:98 > + NSString *const format = @"Experimental%@"; Consider constexpr. > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:100 > + NSString *const format = @"WebKitExperimental%@"; Consider constexpr. > Source/WebKit/WebAuthnProcess/mac/WebAuthnProcessMac.mm:56 > _LSSetApplicationInformationItem(kLSDefaultSessionID, _LSGetCurrentApplicationASN(), _kLSDisplayNameKey, (CFStringRef)applicationName, nullptr); bridge_cast?
David Kilzer (:ddkilzer)
Comment 3 2021-10-27 18:01:31 PDT
Applying all of these changes. Thanks!
David Kilzer (:ddkilzer)
Comment 4 2021-10-27 18:01:41 PDT
Created attachment 442659 [details] Patch for landing
David Kilzer (:ddkilzer)
Comment 5 2021-10-27 18:09:43 PDT
Comment on attachment 442659 [details] Patch for landing Marking cq+ since "Patch v1" passed, and this doesn't include any substantive changes.
EWS
Comment 6 2021-10-27 18:44:27 PDT
Committed r284968 (243619@main): <https://commits.webkit.org/243619@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442659 [details].
Note You need to log in before you can comment on or make changes to this bug.