Summary: | [WebKit] Enable -Wformat=2 warnings | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Component: | WebKit2 | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, darin, ews-watchlist, hi, joepeck, kkinnunen, pangle, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2021-10-26 19:31:30 PDT
Created attachment 442559 [details]
Patch v1
Comment on attachment 442559 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=442559&action=review > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:98 > + NSString *const format = @"Experimental%@"; Consider constexpr. > Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:100 > + NSString *const format = @"WebKitExperimental%@"; Consider constexpr. > Source/WebKit/WebAuthnProcess/mac/WebAuthnProcessMac.mm:56 > _LSSetApplicationInformationItem(kLSDefaultSessionID, _LSGetCurrentApplicationASN(), _kLSDisplayNameKey, (CFStringRef)applicationName, nullptr); bridge_cast? Applying all of these changes. Thanks! Created attachment 442659 [details]
Patch for landing
Comment on attachment 442659 [details]
Patch for landing
Marking cq+ since "Patch v1" passed, and this doesn't include any substantive changes.
Committed r284968 (243619@main): <https://commits.webkit.org/243619@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442659 [details]. |