Bug 232358

Summary: [ANGLE] Enable -Wformat=2 warnings
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: ANGLEAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, kpiddington, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/angleproject/issues/detail?id=6623
Attachments:
Description Flags
Patch v1
none
Patch v2 none

Description David Kilzer (:ddkilzer) 2021-10-26 19:03:19 PDT 
Enable -Wformat=2 warnings in the ANGLE project.

This includes -Wformat-nonliteral among other warnings.

<rdar://problem/84568935>
Comment 1 David Kilzer (:ddkilzer) 2021-10-26 19:14:12 PDT 
Created attachment 442555 [details]
Patch v1
Comment 2 EWS Watchlist 2021-10-26 19:15:01 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-10-26 22:39:51 PDT 
It would be most beneficial to add this upstream in ANGLE in https://chromium.googlesource.com/angle/angle . We're actively in the process of upstreaming all of Apple's changes in preparation for taking a new ANGLE snapshot.

Kyle (CC'd) can also help with this.
Comment 4 David Kilzer (:ddkilzer) 2021-10-27 00:30:00 PDT 
(In reply to Kenneth Russell from comment #3)
> It would be most beneficial to add this upstream in ANGLE in
> https://chromium.googlesource.com/angle/angle . We're actively in the
> process of upstreaming all of Apple's changes in preparation for taking a
> new ANGLE snapshot.
> 
> Kyle (CC'd) can also help with this.

Yep, I filed <https://bugs.chromium.org/p/angleproject/issues/detail?id=6623> to track upstreaming.  It’s in the See Also field as well.
Comment 5 David Kilzer (:ddkilzer) 2021-10-27 18:06:54 PDT 
Created attachment 442661 [details]
Patch v2
Comment 6 David Kilzer (:ddkilzer) 2021-10-27 18:07:39 PDT 
(In reply to David Kilzer (:ddkilzer) from comment #5)
> Created attachment 442661 [details]
> Patch v2

Use `constexpr const char *` instead of `const char *const`.
Comment 7 David Kilzer (:ddkilzer) 2021-10-29 10:11:39 PDT 
Adding Simon and Jon since I don't know who's reviewing ANGLE patches these days.

This is a pretty simple patch.
Comment 8 EWS 2021-11-01 06:18:02 PDT 
Committed r285102 (243744@main): <https://commits.webkit.org/243744@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442661 [details].