Bug 232354

Summary: webkitdirs.pm should use JSON::XS when available
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, ews-watchlist, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2021-10-26 17:04:42 PDT
JSON::XS is faster than JSON::PP. While it doesn't matter for webkitdirs' own use, where JSONs are tiny, other scripts that import webkitdirs.pm do care.
Attachments
proposed patch (1.35 KB, patch)
2021-10-26 17:08 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2021-10-26 17:08:05 PDT
Created attachment 442544 [details] proposed patch It's intentional that the script doesn't die if import fails - there is a lot of functionality that doesn't require JSON, so it's better to not break everything even in the super unlikely case that JSON::PP cannot be loaded.
dewei_zhu
Comment 2 2021-10-26 17:48:14 PDT
Comment on attachment 442544 [details] proposed patch rme
EWS
Comment 3 2021-10-27 08:29:59 PDT
Committed r284922 (243593@main): <https://commits.webkit.org/243593@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442544 [details].
Radar WebKit Bug Importer
Comment 4 2021-10-27 08:30:26 PDT
<rdar://problem/84710691>
Note You need to log in before you can comment on or make changes to this bug.