| Summary: | Store WPT-style fuzzy pixel matching data in ImageDiffResult | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, glenn, gsnedders, jbedard, mrobinson, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 232365 | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2021-10-26 16:42:40 PDT
Created attachment 442542 [details]
Patch
Comment on attachment 442542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442542&action=review > Tools/Scripts/webkitpy/port/image_diff.py:147 > + m = re.match(b'maxDifference=(\d+); totalPixels=(\d+)', fuzzy_data) I think this should be: m = re.match(br'maxDifference=(\d+); totalPixels=(\d+)', fuzzy_data) which is the source of the style bot failure. |