Bug 232352

Summary: Store WPT-style fuzzy pixel matching data in ImageDiffResult
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Tools / TestsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, gsnedders, jbedard, mrobinson, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232365    
Attachments:
Description Flags
Patch mrobinson: review+

Simon Fraser (smfr)
Reported 2021-10-26 16:42:40 PDT
Store WPT-style fuzzy pixel matching data in ImageDiffResult
Attachments
Patch (17.15 KB, patch)
2021-10-26 16:43 PDT, Simon Fraser (smfr) 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-10-26 16:43:49 PDT
Created attachment 442542 [details] Patch
Martin Robinson
Comment 2 2021-10-27 03:48:42 PDT
Comment on attachment 442542 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442542&action=review > Tools/Scripts/webkitpy/port/image_diff.py:147 > + m = re.match(b'maxDifference=(\d+); totalPixels=(\d+)', fuzzy_data) I think this should be: m = re.match(br'maxDifference=(\d+); totalPixels=(\d+)', fuzzy_data) which is the source of the style bot failure.
Simon Fraser (smfr)
Comment 3 2021-10-27 11:19:36 PDT
https://trac.webkit.org/changeset/284930/webkit
Radar WebKit Bug Importer
Comment 4 2021-10-27 11:20:18 PDT
<rdar://problem/84719334>
Note You need to log in before you can comment on or make changes to this bug.