| Summary: | [macOS][GPUP] Remove access to sysctl properties | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||
| Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, darin, gavin.p, mazander, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Per Arne Vollan
2021-10-26 13:46:19 PDT
Created attachment 442527 [details]
Patch
Comment on attachment 442527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442527&action=review > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:173 > -(deny sysctl*) > +(deny sysctl* (with telemetry)) This change is not mentioned in the change log. What’s the rationale? (In reply to Darin Adler from comment #3) > Comment on attachment 442527 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442527&action=review > > > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:173 > > -(deny sysctl*) > > +(deny sysctl* (with telemetry)) > > This change is not mentioned in the change log. What’s the rationale? This is to get telemetry for sysctl properties we might need to add in the future when new features being are added to the GPU process. Thanks for reviewing! Comment on attachment 442527 [details]
Patch
Thanks for reviewing!
Committed r285606 (244110@main): <https://commits.webkit.org/244110@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442527 [details]. |