Bug 232311

Summary: [AppSSO] Avoid attempting to display a nil view controller
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ddkilzer, ews-watchlist, jiewen_tan, katherine_cheney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2021-10-26 09:29:11 PDT 
Crash logs indicate that it is possible for the delegate for an AppSSO authentication to get called after the view has been dismissed (e.g., when a user grows impatient with a slow authentication).

Rather than crashing, we should clean up the session state and make it ready for a new attempt.
Comment 1 Brent Fulgham 2021-10-26 09:29:57 PDT 
<rdar://problem/55199117>
Comment 2 Brent Fulgham 2021-10-26 09:33:46 PDT 
Created attachment 442499 [details]
Patch
Comment 3 EWS 2021-10-26 14:13:08 PDT 
Committed r284896 (243573@main): <https://commits.webkit.org/243573@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442499 [details].