Bug 232305 – build broken on ubuntu 18.04

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Daniel Kolesa]

The 18.04 builder has been broken for a while https://build.webkit.org/#/builders/71 because of a compiler ICE.

[Daniel Kolesa]

Created attachment 442492 [details]
patch

This is a workaround that gets over the segfault. It should not affect other compilers.

[Alexey Proskuryakov]

Comment on attachment 442492 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442492&action=review

> Source/WebCore/ChangeLog:12
> +        Thes sections of the code trigger an internal compiler error with
> +        GCC 8.4, segfaulting the compiler. This adds a workaround that
> +        makes it work again.

Could you please post the gcc bug report link here?

[Daniel Kolesa]

I'm not aware of a GCC bug report yet, this is a new issue (the WeakPtr refactoring is recent)

There is GCC 8.5 already, but ubuntu 18.04 does not ship with it (it would be good to test if the problem still happens in 8.5)

[Daniel Kolesa]

that said, the .5 release tends to be the last one, so I'd expect there won't be any more gcc 8 fixes either way

[Daniel Kolesa]

indeed, there is no more development in the gcc8 branch: https://github.com/gcc-mirror/gcc/commits/releases/gcc-8

[EWS]

Committed r285101 (243743@main): <https://commits.webkit.org/243743@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442492 [details].

[Radar WebKit Bug Importer]

<rdar://problem/84873634>