Bug 232292

Summary: [ App Privacy Report ] Restoring a session after clearing the cache results in app initiated loads in Safari
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: New BugsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Kate Cheney 2021-10-25 19:36:05 PDT
[ App Privacy Report ] Restoring a session after clearing the cache results in app initiated loads in Safari
Comment 1 Kate Cheney 2021-10-25 19:37:33 PDT
Created attachment 442454 [details]
Patch
Comment 2 Brent Fulgham 2021-10-25 19:45:38 PDT
Comment on attachment 442454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442454&action=review

R=me

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1898
> +    if (documentLoader)

If document!oader isn’t used elsewhere, I’d just declare it in the if statement:

If (auto* documentLoadwr = corePage()….
Comment 3 Kate Cheney 2021-10-26 09:36:58 PDT
Created attachment 442500 [details]
Patch for landing
Comment 4 Kate Cheney 2021-10-26 09:37:17 PDT
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 442454 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442454&action=review
> 
> R=me
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:1898
> > +    if (documentLoader)
> 
> If document!oader isn’t used elsewhere, I’d just declare it in the if
> statement:
> 
> If (auto* documentLoadwr = corePage()….

Thanks! Fixed in PFL
Comment 5 EWS 2021-10-26 10:06:50 PDT
Committed r284875 (243552@main): <https://commits.webkit.org/243552@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442500 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-26 10:07:20 PDT
<rdar://problem/84668784>