Bug 232292

Summary: [ App Privacy Report ] Restoring a session after clearing the cache results in app initiated loads in Safari
Product: WebKit Reporter: Kate Cheney <katherine_cheney>
Component: New BugsAssignee: Kate Cheney <katherine_cheney>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Kate Cheney
Reported 2021-10-25 19:36:05 PDT
[ App Privacy Report ] Restoring a session after clearing the cache results in app initiated loads in Safari
Attachments
Patch (4.53 KB, patch)
2021-10-25 19:37 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.50 KB, patch)
2021-10-26 09:36 PDT, Kate Cheney 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kate Cheney
Comment 1 2021-10-25 19:37:33 PDT
Created attachment 442454 [details] Patch
Brent Fulgham
Comment 2 2021-10-25 19:45:38 PDT
Comment on attachment 442454 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442454&action=review R=me > Source/WebKit/WebProcess/WebPage/WebPage.cpp:1898 > + if (documentLoader) If document!oader isn’t used elsewhere, I’d just declare it in the if statement: If (auto* documentLoadwr = corePage()….
Kate Cheney
Comment 3 2021-10-26 09:36:58 PDT
Created attachment 442500 [details] Patch for landing
Kate Cheney
Comment 4 2021-10-26 09:37:17 PDT
(In reply to Brent Fulgham from comment #2) > Comment on attachment 442454 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442454&action=review > > R=me > > > Source/WebKit/WebProcess/WebPage/WebPage.cpp:1898 > > + if (documentLoader) > > If document!oader isn’t used elsewhere, I’d just declare it in the if > statement: > > If (auto* documentLoadwr = corePage()…. Thanks! Fixed in PFL
EWS
Comment 5 2021-10-26 10:06:50 PDT
Committed r284875 (243552@main): <https://commits.webkit.org/243552@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442500 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-26 10:07:20 PDT
<rdar://problem/84668784>
Note You need to log in before you can comment on or make changes to this bug.