Bug 232292 - [ App Privacy Report ] Restoring a session after clearing the cache results in app initiated loads in Safari
Summary: [ App Privacy Report ] Restoring a session after clearing the cache results i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kate Cheney
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-25 19:36 PDT by Kate Cheney
Modified: 2021-10-26 10:07 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.53 KB, patch)
2021-10-25 19:37 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Patch for landing (4.50 KB, patch)
2021-10-26 09:36 PDT, Kate Cheney 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kate Cheney 2021-10-25 19:36:05 PDT 
[ App Privacy Report ] Restoring a session after clearing the cache results in app initiated loads in Safari
Comment 1 Kate Cheney 2021-10-25 19:37:33 PDT 
Created attachment 442454 [details]
Patch
Comment 2 Brent Fulgham 2021-10-25 19:45:38 PDT 
Comment on attachment 442454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442454&action=review

R=me

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1898
> +    if (documentLoader)

If document!oader isn’t used elsewhere, I’d just declare it in the if statement:

If (auto* documentLoadwr = corePage()….
Comment 3 Kate Cheney 2021-10-26 09:36:58 PDT 
Created attachment 442500 [details]
Patch for landing
Comment 4 Kate Cheney 2021-10-26 09:37:17 PDT 
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 442454 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442454&action=review
> 
> R=me
> 
> > Source/WebKit/WebProcess/WebPage/WebPage.cpp:1898
> > +    if (documentLoader)
> 
> If document!oader isn’t used elsewhere, I’d just declare it in the if
> statement:
> 
> If (auto* documentLoadwr = corePage()….

Thanks! Fixed in PFL
Comment 5 EWS 2021-10-26 10:06:50 PDT 
Committed r284875 (243552@main): <https://commits.webkit.org/243552@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442500 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-26 10:07:20 PDT 
<rdar://problem/84668784>