Bug 232274
| Summary: | external/wpt/css/css-tables/tentative/colspan-redistribution.html failing on Safari and Webkit | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | aanala |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, bfulgham, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | Other | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
aanala
Below wpt test is failing on Safari and Webkit
external/wpt/css/css-tables/tentative/colspan-redistribution.html
https://crrev.com/888473
Cl: https://chromium-review.googlesource.com/c/chromium/src/+/2935771
Chromium Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1214206
Mozilla test failure bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1650712
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/84899911>
aanala
Below is the wpt.fyi test link for
wpt/css/css-tables/tentative/colspan-redistribution.html
https://wpt.fyi/results/css/css-tables/tentative/colspan-redistribution.html?label=master&product=chrome%5Bexperimental%5D&product=edge&product=firefox&product=safari&product=webkitgtk&aligned
Ahmad Saleem
Merging Blink Commit:
columnMaxLogicalWidth = std::max(columnMaxLogicalWidth, columnMinLogicalWidth);
m_layoutStruct[pos].effectiveMaxLogicalWidth = std::max(m_layoutStruct[pos].effectiveMaxLogicalWidth, columnMaxLogicalWidth);
Here: https://github.com/WebKit/WebKit/blob/2eed0466d7087a67e3b65404c23d3e1622e6ae15/Source/WebCore/rendering/AutoTableLayout.cpp#L430
__
It does not progress below test case though, we might have other issue in handling colspan, which we might need to fix before doing this.
Ahmad Saleem
https://chromium.googlesource.com/chromium/src.git/+/f4f73107c92b6434606775c84e0440a0f2aaeb53 <- this commit