Summary: | [macOS][GPUP] Block access to mach register | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, gavin.p, mazander, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Per Arne Vollan
2021-10-25 12:04:33 PDT
Created attachment 442392 [details]
Patch
Comment on attachment 442392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442392&action=review > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:-690 > -(allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$")) I think this is needed for profiling GL content in the GPU Process. I'm not sure it's safe to remove, unless you have tested using the graphics tools on the GPU Process. Created attachment 444072 [details]
Patch
(In reply to Brent Fulgham from comment #3) > Comment on attachment 442392 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442392&action=review > > > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:-690 > > -(allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$")) > > I think this is needed for profiling GL content in the GPU Process. I'm not > sure it's safe to remove, unless you have tested using the graphics tools on > the GPU Process. That is a good point. I kept this rule for internal builds, which is the way we've done it in the WebContent process. Thanks for reviewing! Comment on attachment 444072 [details]
Patch
r=me
Committed r285735 (244194@main): <https://commits.webkit.org/244194@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444072 [details]. |