Bug 232259 – [macOS][GPUP] Block access to mach register

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Per Arne Vollan]

Based on telemetry, block access to mach register in the GPU process on macOS.

[Radar WebKit Bug Importer]

<rdar://problem/84624488>

[Per Arne Vollan]

Created attachment 442392 [details]
Patch

[Brent Fulgham]

Comment on attachment 442392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442392&action=review

> Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:-690
> -(allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$"))

I think this is needed for profiling GL content in the GPU Process. I'm not sure it's safe to remove, unless you have tested using the graphics tools on the GPU Process.

[Per Arne Vollan]

Created attachment 444072 [details]
Patch

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 442392 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=442392&action=review
> 
> > Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:-690
> > -(allow mach-register (with telemetry) (global-name-regex #"^_oglprof_attach_<[0-9]+>$"))
> 
> I think this is needed for profiling GL content in the GPU Process. I'm not
> sure it's safe to remove, unless you have tested using the graphics tools on
> the GPU Process.

That is a good point. I kept this rule for internal builds, which is the way we've done it in the WebContent process.

Thanks for reviewing!

[Brent Fulgham]

Comment on attachment 444072 [details]
Patch

r=me

[EWS]

Committed r285735 (244194@main): <https://commits.webkit.org/244194@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444072 [details].