Bug 232246

Summary: Refactor CSSToStyleMap::mapAnimationTimingFunction() to use TimingFunction::createFromCSSValue()
Product: WebKit Reporter: Antoine Quint <graouts>
Component: CSSAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, koivisto, macpherson, menard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2021-10-25 10:25:19 PDT
Refactor CSSToStyleMap::mapAnimationTimingFunction() to use TimingFunction::createFromCSSValue()
Attachments
Patch (3.84 KB, patch)
2021-10-25 10:26 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2021-10-25 10:26:00 PDT
Created attachment 442381 [details] Patch
Dean Jackson
Comment 2 2021-10-25 10:27:43 PDT
Comment on attachment 442381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442381&action=review > Source/WebCore/css/CSSToStyleMap.cpp:-461 > - return; Might as well keep the return and use "if" instead of "else if".
Antoine Quint
Comment 3 2021-10-25 10:28:53 PDT
(In reply to Dean Jackson from comment #2) > Comment on attachment 442381 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442381&action=review > > > Source/WebCore/css/CSSToStyleMap.cpp:-461 > > - return; > > Might as well keep the return and use "if" instead of "else if". But it's one whole extra line of code!
EWS
Comment 4 2021-10-26 00:06:35 PDT
Committed r284856 (243533@main): <https://commits.webkit.org/243533@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442381 [details].
Radar WebKit Bug Importer
Comment 5 2021-10-26 00:07:19 PDT
<rdar://problem/84650836>
Note You need to log in before you can comment on or make changes to this bug.