| Summary: | Refactor CSSToStyleMap::mapAnimationTimingFunction() to use TimingFunction::createFromCSSValue() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | CSS | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | dino, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, koivisto, macpherson, menard, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2021-10-25 10:25:19 PDT
Created attachment 442381 [details]
Patch
Comment on attachment 442381 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442381&action=review > Source/WebCore/css/CSSToStyleMap.cpp:-461 > - return; Might as well keep the return and use "if" instead of "else if". (In reply to Dean Jackson from comment #2) > Comment on attachment 442381 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=442381&action=review > > > Source/WebCore/css/CSSToStyleMap.cpp:-461 > > - return; > > Might as well keep the return and use "if" instead of "else if". But it's one whole extra line of code! Committed r284856 (243533@main): <https://commits.webkit.org/243533@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442381 [details]. |