Bug 232183
| Summary: | RemoteRenderingBackend::m_remoteDisplayLists should not be a WeakHashSet | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> |
| Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | cdumez, kkinnunen |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Wenson Hsieh
SSIA
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Wenson Hsieh
This bug tracks addressing https://bugs.webkit.org/show_bug.cgi?id=232113#c10, where the WeakHashSet `m_remoteDisplayLists` is accessed from both the rendering backend thread and the main thread in the GPU process.
This is dangerous, given that WeakPtr itself cannot be used from different threads.
We should make this a HashSet or HashMap of Ref/RefPtr, and then manually remove entries from this map when releasing cached image buffers.
Wenson Hsieh
I think I'm going to fix this as a part of https://bugs.webkit.org/show_bug.cgi?id=232179, since both bugs can be addressed by very similar changes.
Wenson Hsieh
*** This bug has been marked as a duplicate of bug 232179 ***