Bug 232174

Summary: WebKit ought to be able to play videos without Content-Length HTTP header fields and without range support
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, ggaren, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2021-10-22 14:04:32 PDT
WebKit ought to be able to play videos without Content-Length HTTP header fields and without range support
Comment 1 Alex Christensen 2021-10-22 14:17:10 PDT
Created attachment 442199 [details]
Patch
Comment 2 Geoffrey Garen 2021-10-22 14:28:52 PDT
Comment on attachment 442199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442199&action=review

r=me

> Source/WebCore/ChangeLog:10
> +        AVFoundation doesn't like it when you give it a range like 0-1/* because it doesn't know the content length.
> +        To work around this, wait until the entire video is loaded then respond with a known length.
> +        This isn't great, but it's better than not playing the video at all.

So, was the old behavior a race condition based on how fast the video loaded? How did this every work at all?
Comment 3 Alex Christensen 2021-10-25 09:28:12 PDT
Created attachment 442376 [details]
Patch
Comment 4 Alex Christensen 2021-10-25 09:28:25 PDT
It never did work.
Comment 5 EWS 2021-10-25 12:25:33 PDT
Committed r284816 (243508@main): <https://commits.webkit.org/243508@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442376 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-25 12:26:20 PDT
<rdar://problem/84625376>