Bug 232170

Summary: Add support for rel="noopener/noreferrer" on <form> elements
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: FormsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, changseok, darin, esprehn+autocc, ews-watchlist, ggaren, gyuyoung.kim, japhet, kondapallykalyan, mifenton, sam, webkit-bug-importer, wenson_hsieh, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232182
Bug Depends on:    
Bug Blocks: 232243    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-10-22 13:34:03 PDT
Add support for rel="opener/noopener/noreferrer" on <form> elements.
Attachments
Patch (8.64 KB, patch)
2021-10-22 13:37 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (14.45 KB, patch)
2021-10-22 13:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (27.24 KB, patch)
2021-10-22 15:16 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (31.85 KB, patch)
2021-10-22 15:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (32.51 KB, patch)
2021-10-22 16:14 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (34.85 KB, patch)
2021-10-22 16:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (34.59 KB, patch)
2021-10-23 14:41 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-10-22 13:37:31 PDT
Created attachment 442193 [details] Patch
Chris Dumez
Comment 2 2021-10-22 13:55:35 PDT
Created attachment 442196 [details] Patch
Chris Dumez
Comment 3 2021-10-22 15:16:58 PDT
Created attachment 442203 [details] Patch
Chris Dumez
Comment 4 2021-10-22 15:32:06 PDT
Created attachment 442204 [details] Patch
Chris Dumez
Comment 5 2021-10-22 16:14:33 PDT
Created attachment 442213 [details] Patch
Chris Dumez
Comment 6 2021-10-22 16:38:00 PDT
Created attachment 442222 [details] Patch
Darin Adler
Comment 7 2021-10-23 06:13:31 PDT
Comment on attachment 442222 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442222&action=review > Source/WebCore/html/HTMLFormElement.cpp:78 > +static FormRelAttributes parseFormRelAttributes(StringView relAttribute) I would call this "string". > Source/WebCore/html/HTMLFormElement.cpp:80 > + FormRelAttributes relAttributes; I would call this "attributes".
Chris Dumez
Comment 8 2021-10-23 14:41:00 PDT
Created attachment 442280 [details] Patch
EWS
Comment 9 2021-10-23 15:27:01 PDT
Committed r284749 (243458@main): <https://commits.webkit.org/243458@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442280 [details].
Radar WebKit Bug Importer
Comment 10 2021-10-23 15:28:18 PDT
<rdar://problem/84583172>
Note You need to log in before you can comment on or make changes to this bug.