Bug 232151

Summary: Regression (r284610): [ iOS BigSur wk2 ] http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html is failing
Product: WebKit Reporter: ayumi_kojima
Component: New BugsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, cdumez, cfleizach, ggaren, Keyante.james, tyler_w, webkit-bot-watchers-bugzilla, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232150
Attachments:
Description Flags
Patch
none
Patch none

ayumi_kojima
Reported 2021-10-22 09:37:46 PDT
http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html Is constantly failing on iOS 15 and BigSur wk2 Debug. History: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fsecurity%2Fwindow-opened-from-sandboxed-iframe-should-inherit-sandbox.html Result page: https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-WK2-Tests/r284676%20(270)/results.html# Diff: --- /Volumes/Data/worker/ios-simulator-15-release-tests-wk2/build/layout-test-results/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt +++ /Volumes/Data/worker/ios-simulator-15-release-tests-wk2/build/layout-test-results/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-actual.txt @@ -1,2 +1 @@ -CONSOLE MESSAGE: Blocked script execution in 'http://127.0.0.1:8000/security/resources/page-executing-javascript.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.
Attachments
Patch (4.47 KB, patch)
2021-10-22 11:59 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.39 KB, patch)
2021-10-22 12:24 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-22 09:40:30 PDT
<rdar://problem/84552682>
ayumi_kojima
Comment 2 2021-10-22 09:47:22 PDT
imported/w3c/web-platform-tests/html/browsers/the-window-object/noopener-noreferrer-sizing.window.html is also flaky failing on iOS 15 (iPhone). This might be related.
ayumi_kojima
Comment 3 2021-10-22 09:54:37 PDT
I was able to reproduce the failure locally on iOS 15 sim using run-webkit-tests http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html --iterations 50 --exit-after-n-failures 1 The passed with r284604 and failed with r284612.
ayumi_kojima
Comment 4 2021-10-22 10:51:51 PDT
Looking at the change sets, I think it is either r284612 or r284610 that caused the regression.
Tyler Wilcock
Comment 5 2021-10-22 10:54:38 PDT
I would guess the latter (https://commits.webkit.org/r284610), since the former only affects the accessibility tree.
ayumi_kojima
Comment 6 2021-10-22 10:55:45 PDT
Thank you Tyler!
ayumi_kojima
Comment 7 2021-10-22 11:36:05 PDT
Marked expectations while investigating https://trac.webkit.org/changeset/284701/webkit
Chris Dumez
Comment 8 2021-10-22 11:59:27 PDT
Created attachment 442183 [details] Patch
Chris Dumez
Comment 9 2021-10-22 12:24:50 PDT
Created attachment 442185 [details] Patch
ayumi_kojima
Comment 10 2021-10-22 14:11:01 PDT
*** Bug 232150 has been marked as a duplicate of this bug. ***
Ryan Haddad
Comment 11 2021-10-22 15:23:11 PDT
Comment on attachment 442185 [details] Patch rs=me
EWS
Comment 12 2021-10-22 15:53:50 PDT
Committed r284723 (243435@main): <https://commits.webkit.org/243435@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442185 [details].
Chris Dumez
Comment 13 2021-10-25 12:30:25 PDT
Committed r284817 (243509@main): <https://commits.webkit.org/243509@main>
Keyante James
Comment 14 2021-11-21 18:47:05 PST
Don't sell sell or use my personal information or data for anything other than my accounts
Note You need to log in before you can comment on or make changes to this bug.