Bug 232151 - Regression (r284610): [ iOS BigSur wk2 ] http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html is failing
Summary: Regression (r284610): [ iOS BigSur wk2 ] http/tests/security/window-opened-fr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
: 232150 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-10-22 09:37 PDT by ayumi_kojima
Modified: 2021-11-21 18:47 PST (History)
10 users (show)

See Also:

Attachments
Patch (4.47 KB, patch)
2021-10-22 11:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.39 KB, patch)
2021-10-22 12:24 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description ayumi_kojima 2021-10-22 09:37:46 PDT 
http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html

Is constantly failing on iOS 15 and BigSur wk2 Debug.

History: https://results.webkit.org/?suite=layout-tests&test=http%2Ftests%2Fsecurity%2Fwindow-opened-from-sandboxed-iframe-should-inherit-sandbox.html

Result page: https://build.webkit.org/results/Apple-iOS-15-Simulator-Release-WK2-Tests/r284676%20(270)/results.html#

Diff:

--- /Volumes/Data/worker/ios-simulator-15-release-tests-wk2/build/layout-test-results/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt
+++ /Volumes/Data/worker/ios-simulator-15-release-tests-wk2/build/layout-test-results/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-actual.txt
@@ -1,2 +1 @@
-CONSOLE MESSAGE: Blocked script execution in 'http://127.0.0.1:8000/security/resources/page-executing-javascript.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.
Comment 1 Radar WebKit Bug Importer 2021-10-22 09:40:30 PDT 
<rdar://problem/84552682>
Comment 2 ayumi_kojima 2021-10-22 09:47:22 PDT 
imported/w3c/web-platform-tests/html/browsers/the-window-object/noopener-noreferrer-sizing.window.html is also flaky failing on iOS 15 (iPhone). This might be related.
Comment 3 ayumi_kojima 2021-10-22 09:54:37 PDT 
I was able to reproduce the failure locally on iOS 15 sim using run-webkit-tests http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox.html --iterations 50 --exit-after-n-failures 1

The passed with r284604 and failed with r284612.
Comment 4 ayumi_kojima 2021-10-22 10:51:51 PDT 
Looking at the change sets, I think it is either r284612 or r284610 that caused the regression.
Comment 5 Tyler Wilcock 2021-10-22 10:54:38 PDT 
I would guess the latter (https://commits.webkit.org/r284610), since the former only affects the accessibility tree.
Comment 6 ayumi_kojima 2021-10-22 10:55:45 PDT 
Thank you Tyler!
Comment 7 ayumi_kojima 2021-10-22 11:36:05 PDT 
Marked expectations while investigating https://trac.webkit.org/changeset/284701/webkit
Comment 8 Chris Dumez 2021-10-22 11:59:27 PDT 
Created attachment 442183 [details]
Patch
Comment 9 Chris Dumez 2021-10-22 12:24:50 PDT 
Created attachment 442185 [details]
Patch
Comment 10 ayumi_kojima 2021-10-22 14:11:01 PDT 
*** Bug 232150 has been marked as a duplicate of this bug. ***
Comment 11 Ryan Haddad 2021-10-22 15:23:11 PDT 
Comment on attachment 442185 [details]
Patch

rs=me
Comment 12 EWS 2021-10-22 15:53:50 PDT 
Committed r284723 (243435@main): <https://commits.webkit.org/243435@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442185 [details].
Comment 13 Chris Dumez 2021-10-25 12:30:25 PDT 
Committed r284817 (243509@main): <https://commits.webkit.org/243509@main>
Comment 14 Keyante James 2021-11-21 18:47:05 PST 
Don't sell sell or use my personal information or data for anything other than my accounts