Bug 232137

Summary: Factor style resolver context arguments into a struct
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, cmarcelo, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, glenn, graouts, gyuyoung.kim, jer.noble, kangil.han, kondapallykalyan, macpherson, menard, mifenton, pdr, philipj, sabouhallawa, schenney, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=232160
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Antti Koivisto
Reported 2021-10-22 03:04:13 PDT
Style resolver needs context to resolve things correctly. It is currently provided in an ad-hoc manner as a collection of function arguments. Factor them into a struct for consistency and future extensibility.
Attachments
Patch (54.42 KB, patch)
2021-10-22 03:06 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (55.10 KB, patch)
2021-10-22 03:18 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (74.28 KB, patch)
2021-10-22 05:36 PDT, Antti Koivisto 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (74.50 KB, patch)
2021-10-22 07:07 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (74.88 KB, patch)
2021-10-22 08:47 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-10-22 03:06:31 PDT
Created attachment 442140 [details] Patch
Antti Koivisto
Comment 2 2021-10-22 03:18:28 PDT
Created attachment 442141 [details] Patch
Antti Koivisto
Comment 3 2021-10-22 05:36:16 PDT
Created attachment 442152 [details] Patch
Antti Koivisto
Comment 4 2021-10-22 07:07:44 PDT
Created attachment 442161 [details] Patch
Antoine Quint
Comment 5 2021-10-22 08:27:30 PDT
Comment on attachment 442161 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442161&action=review > Source/WebCore/style/StyleResolver.h:83 > +struct ResolveContext { Shouldn't this be called ResolutionContext rather? Resolve is a noun too, but it doesn't mean the same thing, and a noun seems better than a verb here.
Antti Koivisto
Comment 6 2021-10-22 08:28:53 PDT
> Shouldn't this be called ResolutionContext rather? Resolve is a noun too, > but it doesn't mean the same thing, and a noun seems better than a verb here. Good idea
Antti Koivisto
Comment 7 2021-10-22 08:47:11 PDT
Created attachment 442168 [details] Patch
EWS
Comment 8 2021-10-22 09:56:42 PDT
Committed r284693 (243412@main): <https://commits.webkit.org/243412@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442168 [details].
Radar WebKit Bug Importer
Comment 9 2021-10-22 09:57:17 PDT
<rdar://problem/84553304>
Carlos Alberto Lopez Perez
Comment 10 2021-10-22 11:20:35 PDT
(In reply to EWS from comment #8) > Committed r284693 (243412@main): <https://commits.webkit.org/243412@main> > > All reviewed patches have been landed. Closing bug and clearing flags on > attachment 442168 [details]. This caused the clean build of WebKitGTK to break with a linking error. Reported at bug 232160
Note You need to log in before you can comment on or make changes to this bug.