Bug 232126

Summary:

AX: Keyboard-focusable leaf nodes with labels should be accessible elements on iOS

Product:

WebKit

Reporter:

Tyler Wilcock <tyler_w>

Component:

Accessibility

Assignee:

Tyler Wilcock <tyler_w>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, alehm, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP for EWS	none
Test only -- do not review or cq+	none
Patch	none

Tyler Wilcock

Reported 2021-10-21 18:38:29 PDT

Keyboard-focusable leaf nodes with labels should be accessible elements on iOS

Attachments
WIP for EWS (8.68 KB, patch) 2021-10-21 18:47 PDT, Tyler Wilcock	no flags	Details Formatted Diff Diff
Test only -- do not review or cq+ (3.76 KB, patch) 2021-10-21 19:19 PDT, Tyler Wilcock	no flags	Details Formatted Diff Diff
Patch (11.91 KB, patch) 2021-10-25 09:53 PDT, Tyler Wilcock	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-10-21 18:38:39 PDT

<rdar://problem/84531720>

Tyler Wilcock

Comment 2 2021-10-21 18:47:12 PDT

Created attachment 442102 [details] WIP for EWS

Tyler Wilcock

Comment 3 2021-10-21 19:19:35 PDT

Created attachment 442103 [details] Test only -- do not review or cq+

Tyler Wilcock

Comment 4 2021-10-25 09:53:28 PDT

Created attachment 442379 [details] Patch

EWS

Comment 5 2021-10-25 10:58:08 PDT

Committed r284796 (243504@main): <https://commits.webkit.org/243504@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442379 [details].

alehm

Comment 6 2021-11-30 10:11:06 PST

Hi Tyler, do you have any details of when this fix can be released (i.e. an iOS version)?

Tyler Wilcock

Comment 7 2021-11-30 18:14:12 PST

Really sorry, but I don't know exactly when it'll be included in a release. Also, just want to point out this comment again in case you missed it: https://bugs.webkit.org/show_bug.cgi?id=223492#c16 The patch in this bug makes keyboard-focusable leaf nodes with labels accessible elements, but VoiceOver won't read them unless they also have a width and height >= 1px. If that's a problem for your use-case, we can open up a follow-up bug.

alehm

Comment 8 2021-12-01 11:46:18 PST

Oh, I indeed missed that, so sorry about that. Yeah, our keyboard-focusable leaf nodes will be >= 1px. Thanks!

Note You need to log in before you can comment on or make changes to this bug.