Summary: | Make it easier for ports to define custom UI for media controls | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | ||||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Eric Carlson
2009-01-09 11:49:05 PST
Created attachment 26566 [details]
proposed patch
err, I meant to say "we should NOT assume that hit testing a control element's bounding box is sufficient" Comment on attachment 26566 [details]
proposed patch
I would expect this to be either:
const String& or String. I'm not sure what const String would do for you.
The preferred webkit style is no else after return:
+ if (renderer() && renderer()->style()->hasAppearance())
+ return theme()->hitTestMediaControlPart(renderer(), absPoint);
+ else
+ return false;
No need for "o" here:
+ virtual bool hitTestMediaControlPart(RenderObject* o, const IntPoint& absPoint);
Otherwise it looks fine. If you're a commiter, go ahead and fix the nits and land, no need to see another patch.
Committed revision 39782 Created attachment 26665 [details]
Change media controls theming to be overrides instead of complete ruleset
Re-opening as I have a patch to how this works. Talked to Eric about this on IRC. Talked to Eric Carlson that is :) Created attachment 26666 [details]
Updated patch with changelog and #ifdefs in RenderTheme
Comment on attachment 26666 [details]
Updated patch with changelog and #ifdefs in RenderTheme
Looks good to me!
|