Bug 232091

Summary: [LFC][IFC] Add support for checking leading collapsible whitespace in InlineContentBreaker::processOverflowingContent
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2021-10-21 09:29:56 PDT
ssia
Comment 1 zalan 2021-10-21 09:39:20 PDT
Created attachment 442043 [details]
Patch
Comment 2 zalan 2021-10-21 16:05:56 PDT
Created attachment 442079 [details]
Patch
Comment 3 Antti Koivisto 2021-10-22 06:02:43 PDT
Comment on attachment 442079 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=442079&action=review

> Source/WebCore/ChangeLog:12
> +
> +        This patch ensures that the leading collapsible whitespace on the continuous run is taken
> +        into account when checking if the otherwise overflowing content may fit the line.
> +        e.g.
> +        <span style="white-space: nowrap">no_wrap </span><span> yes_wrap</span>
> +        The " yes_wrap" content has a collapsible leading whitespace here. 

This could mention that the tests are part of the upcoming patches.
Comment 4 zalan 2021-10-22 06:08:45 PDT
Created attachment 442156 [details]
Patch
Comment 5 EWS 2021-10-22 06:44:08 PDT
Committed r284678 (243398@main): <https://commits.webkit.org/243398@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 442156 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-22 06:45:15 PDT
<rdar://problem/84547740>