Bug 232070

Summary: StreamConnectionWorkQueue::processStreams() has a incorrect protection ref
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebKit2Assignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: kkinnunen, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Kimmo Kinnunen
Reported 2021-10-21 01:40:33 PDT
`StreamConnectionWorkQueue::processStreams()` has a incorrect protection ref The `processStreams()` runs in the work queue thread. It cannot hold the last ref of itself, as that would mean that it would destroy itself in the thread it runs. This is not possible.
Attachments
Patch (3.12 KB, patch)
2021-10-21 01:51 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.74 KB, patch)
2021-10-22 01:53 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-10-21 01:51:34 PDT
Created attachment 441997 [details] Patch
Wenson Hsieh
Comment 2 2021-10-21 08:27:16 PDT
Comment on attachment 441997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441997&action=review > Source/WebKit/ChangeLog:12 > + task, and since `stop()` waits until queue has executed the In that case, I think we should consider renaming `stop()` to `stopAndWaitForTasksToComplete()`, to make it clear that it must always block on the work queue thread.
Kimmo Kinnunen
Comment 3 2021-10-22 01:53:13 PDT
Created attachment 442134 [details] Patch for landing
Kimmo Kinnunen
Comment 4 2021-10-22 07:02:55 PDT
(In reply to Wenson Hsieh from comment #2) > Comment on attachment 441997 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=441997&action=review > > > Source/WebKit/ChangeLog:12 > > + task, and since `stop()` waits until queue has executed the > > In that case, I think we should consider renaming `stop()` to > `stopAndWaitForTasksToComplete()`, to make it clear that it must always > block on the work queue thread. Thanks, added it as stopAndWaitForCompletion to use same naming as Thread
EWS
Comment 5 2021-10-22 07:38:49 PDT
Committed r284681 (243401@main): <https://commits.webkit.org/243401@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442134 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-22 07:39:14 PDT
<rdar://problem/84549004>
Note You need to log in before you can comment on or make changes to this bug.