Bug 232063

Summary:

Minimize WebCore/Header.h includes inside WebCore

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW ---

Severity:

Normal

CC:

ap, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP Patch	ews-feeder: commit-queue-

Description Don Olmstead 2021-10-20 17:47:38 PDT

Should be using "Header.h" still unless there's a very very good reason otherwise.

Comment 1 Don Olmstead 2021-10-20 17:48:15 PDT

Created attachment 441968 [details]
WIP Patch

Comment 2 Alexey Proskuryakov 2021-10-20 21:14:47 PDT

Comment on attachment 441968 [details]
WIP Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441968&action=review

> Source/WebCore/platform/ios/WebItemProviderPasteboard.h:-27
> -#import <WebCore/AbstractPasteboard.h>

I do not think that this is right. As WebCore is an implementation detail of WebKit, it should be very easy to promote headers to SPI. And this they should all use framework style includes in this project.

Comment 3 Radar WebKit Bug Importer 2021-10-27 17:48:18 PDT

<rdar://problem/84735872>