Bug 232061

Summary:

[WinCairo] Add additional exports for a SHARED WebCore

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

Tools / Tests

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, annulen, beidson, changseok, cmarcelo, esprehn+autocc, ews-watchlist, galpeter, glenn, gyuyoung.kim, hi, Hironori.Fujii, joepeck, jsbell, kondapallykalyan, luiz, mmaxfield, pangle, pdr, ryuan.choi, sergio

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

232062

Attachments:

Description	Flags
Patch	none

Description Don Olmstead 2021-10-20 17:29:31 PDT

Would like to have the option to do a SHARED WebCore going forward.

Comment 1 Don Olmstead 2021-10-20 17:39:53 PDT

Created attachment 441966 [details]
Patch

Comment 2 Myles C. Maxfield 2021-10-20 20:42:07 PDT

What is a SHARED WebCore?

Comment 3 Don Olmstead 2021-10-21 10:59:36 PDT

(In reply to Myles C. Maxfield from comment #2)
> What is a SHARED WebCore?

SHARED in CMake vernacular for whatever a shared library is on a platform. So .dll for windows, .so for *nix, and a .dylib on OS X.

Comment 4 Myles C. Maxfield 2021-10-21 11:57:21 PDT

I see. Currently, cmake builds WebCore as a static library?

Comment 5 Don Olmstead 2021-10-21 12:58:29 PDT

(In reply to Myles C. Maxfield from comment #4)
> I see. Currently, cmake builds WebCore as a static library?

It depends on the port. WinCairo is currently building it as an OBJECT library which is similar to STATIC. Mac ports would need it to build as SHARED.

Comment 6 Fujii Hironori 2023-02-08 22:11:53 PST

fixed by bug#247944.