Bug 232061

Summary: [WinCairo] Add additional exports for a SHARED WebCore
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, annulen, beidson, changseok, cmarcelo, esprehn+autocc, ews-watchlist, fujii.hironori, galpeter, glenn, gyuyoung.kim, hi, joepeck, jsbell, kondapallykalyan, luiz, mmaxfield, pangle, pdr, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232062    
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2021-10-20 17:29:31 PDT
Would like to have the option to do a SHARED WebCore going forward.
Attachments
Patch (29.26 KB, patch)
2021-10-20 17:39 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2021-10-20 17:39:53 PDT
Created attachment 441966 [details] Patch
Myles C. Maxfield
Comment 2 2021-10-20 20:42:07 PDT
What is a SHARED WebCore?
Don Olmstead
Comment 3 2021-10-21 10:59:36 PDT
(In reply to Myles C. Maxfield from comment #2) > What is a SHARED WebCore? SHARED in CMake vernacular for whatever a shared library is on a platform. So .dll for windows, .so for *nix, and a .dylib on OS X.
Myles C. Maxfield
Comment 4 2021-10-21 11:57:21 PDT
I see. Currently, cmake builds WebCore as a static library?
Don Olmstead
Comment 5 2021-10-21 12:58:29 PDT
(In reply to Myles C. Maxfield from comment #4) > I see. Currently, cmake builds WebCore as a static library? It depends on the port. WinCairo is currently building it as an OBJECT library which is similar to STATIC. Mac ports would need it to build as SHARED.
Fujii Hironori
Comment 6 2023-02-08 22:11:53 PST
fixed by bug#247944.
Note You need to log in before you can comment on or make changes to this bug.