Bug 232052

Summary: [JSC][32bit] Re-enable compileEnumeratorGetByVal fast path
Product: WebKit Reporter: Mikhail R. Gadelha <mikhail>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, xan.lopez, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Mikhail R. Gadelha
Reported 2021-10-20 15:29:18 PDT
[JSC][32bit] Re-enable compileEnumeratorGetByVal fast path
Attachments
Patch (24.58 KB, patch)
2021-10-20 15:33 PDT, Mikhail R. Gadelha 		no flags
DetailsFormatted DiffDiff
Patch (39.47 KB, patch)
2021-10-21 06:18 PDT, Mikhail R. Gadelha 		no flags
DetailsFormatted DiffDiff
Patch (46.42 KB, patch)
2021-10-21 07:11 PDT, Mikhail R. Gadelha 		no flags
DetailsFormatted DiffDiff
Patch (38.41 KB, patch)
2021-10-22 06:21 PDT, Mikhail R. Gadelha 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mikhail R. Gadelha
Comment 1 2021-10-20 15:33:13 PDT
Created attachment 441949 [details] Patch
Mikhail R. Gadelha
Comment 2 2021-10-21 06:18:27 PDT
Created attachment 442013 [details] Patch
Mikhail R. Gadelha
Comment 3 2021-10-21 07:11:05 PDT
Created attachment 442016 [details] Patch
Yusuke Suzuki
Comment 4 2021-10-21 16:05:09 PDT
Comment on attachment 442016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442016&action=review r- since the new code is not great compared to the current 64bit implementation. > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:15891 > + flushRegisters(); > + This is regressing 64bit implementation from the current one. Can you remove it? If this is necessary for 32bit implementation, so please keep 32bit and 64bit implementations separated.
Mikhail R. Gadelha
Comment 5 2021-10-22 06:21:35 PDT
Created attachment 442158 [details] Patch
Yusuke Suzuki
Comment 6 2021-10-22 11:16:14 PDT
Comment on attachment 442158 [details] Patch r=me
EWS
Comment 7 2021-10-22 11:31:57 PDT
Committed r284700 (243417@main): <https://commits.webkit.org/243417@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442158 [details].
Radar WebKit Bug Importer
Comment 8 2021-10-22 11:32:17 PDT
<rdar://problem/84557181>
Xan Lopez
Comment 9 2021-10-23 12:20:49 PDT
*** Bug 230189 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.