| Summary: | [JSC][32bit] Re-enable compileEnumeratorGetByVal fast path | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mikhail R. Gadelha <mikhail> | ||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, xan.lopez, ysuzuki | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Mikhail R. Gadelha
2021-10-20 15:29:18 PDT
Created attachment 441949 [details]
Patch
Created attachment 442013 [details]
Patch
Created attachment 442016 [details]
Patch
Comment on attachment 442016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442016&action=review r- since the new code is not great compared to the current 64bit implementation. > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:15891 > + flushRegisters(); > + This is regressing 64bit implementation from the current one. Can you remove it? If this is necessary for 32bit implementation, so please keep 32bit and 64bit implementations separated. Created attachment 442158 [details]
Patch
Comment on attachment 442158 [details]
Patch
r=me
Committed r284700 (243417@main): <https://commits.webkit.org/243417@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 442158 [details]. *** Bug 230189 has been marked as a duplicate of this bug. *** |