Bug 23205

Summary: Immediate int should be stored in low word of JSValuePtr on x86-64.
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
The patch
none
The patch sam: review+

Gavin Barraclough
Reported 2009-01-08 21:23:27 PST
This will simplify arithmetic, by removing the need to de-tag values.
Attachments
The patch (53.19 KB, patch)
2009-01-08 21:24 PST, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
The patch (53.64 KB, patch)
2009-01-08 21:30 PST, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2009-01-08 21:24:30 PST
Created attachment 26554 [details] The patch
Gavin Barraclough
Comment 2 2009-01-08 21:30:12 PST
Created attachment 26555 [details] The patch
Sam Weinig
Comment 3 2009-01-08 21:48:08 PST
Comment on attachment 26555 [details] The patch Awesome! r=me
Gavin Barraclough
Comment 4 2009-01-09 00:11:24 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/assembler/MacroAssembler.h Sending JavaScriptCore/assembler/X86Assembler.h Sending JavaScriptCore/jit/JIT.cpp Sending JavaScriptCore/jit/JIT.h Sending JavaScriptCore/jit/JITArithmetic.cpp Sending JavaScriptCore/jit/JITCall.cpp Sending JavaScriptCore/jit/JITInlineMethods.h Sending JavaScriptCore/jit/JITPropertyAccess.cpp Sending JavaScriptCore/runtime/JSImmediate.h Sending JavaScriptCore/wtf/Platform.h Transmitting file data ........... Committed revision 39738.
Note You need to log in before you can comment on or make changes to this bug.