Bug 232044

Summary: [WebRTC] Simplify libwebtc Xcode project
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: WebRTCAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 none

Description David Kilzer (:ddkilzer) 2021-10-20 14:20:01 PDT 
Simplify libwebtc Xcode project.

This will fix:
- Install webm headers consistently.
- Remove some duplicate references to C++ source files.
- Remove "Recovered References" folder (for files that don't exist at their path anymore).

<rdar://problem/82743710>
Comment 1 David Kilzer (:ddkilzer) 2021-10-20 16:58:43 PDT 
Created attachment 441956 [details]
Patch v1
Comment 2 youenn fablet 2021-10-21 01:42:02 PDT 
Maybe we should create a separate libwebm Xcode project in the future.
Comment 3 David Kilzer (:ddkilzer) 2021-10-21 03:12:58 PDT 
(In reply to youenn fablet from comment #2)
> Maybe we should create a separate libwebm Xcode project in the future.

I’m not sure it would be worth the extra work to be honest.

I suspect Xcode is faster opening one project with 7 targets vs. one project with 6 subprojects.

Thanks for the review!
Comment 4 David Kilzer (:ddkilzer) 2021-10-21 03:14:06 PDT 
Comment on attachment 441956 [details]
Patch v1

Marking cq+ since this patch needed building, not testing.
Comment 5 EWS 2021-10-21 03:50:35 PDT 
Committed r284599 (243328@main): <https://commits.webkit.org/243328@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441956 [details].