Bug 23199

Summary: WorkerThread shouldn't deref strings on the main thread that it used on the worker thread.
Product: WebKit Reporter: David Levin <levin>
Component: DOMAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 23175    
Attachments:
Description Flags
Patch for bug.
none
Changed to a static create method (instead of using new directly) and added a comment.
none
Diff form last version of the patch: I noticed a bad indentation in one place and fixed it. ap: review+

David Levin
Reported 2009-01-08 16:25:29 PST
Currently, WorkerThread::WorkerThread copies some Strings and a KURL for use on the worker thread. After passing them off to other objects in side of the worker thread (where they get ref/deref'ed), its destructor runs on the main thread and does a deref on these string there. This should mostly work, but there is a potential for some subtle race conditions to occur, so it would be good to clean them up on the WorkerThread.
Attachments
Patch for bug. (4.27 KB, patch)
2009-01-08 16:58 PST, David Levin 		no flags
DetailsFormatted DiffDiff
Changed to a static create method (instead of using new directly) and added a comment. (4.90 KB, patch)
2009-01-09 01:32 PST, David Levin 		no flags
DetailsFormatted DiffDiff
Diff form last version of the patch: I noticed a bad indentation in one place and fixed it. (4.91 KB, patch)
2009-01-09 01:36 PST, David Levin 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2009-01-08 16:58:50 PST
Created attachment 26548 [details] Patch for bug.
David Levin
Comment 2 2009-01-09 01:32:40 PST
Created attachment 26561 [details] Changed to a static create method (instead of using new directly) and added a comment.
David Levin
Comment 3 2009-01-09 01:36:08 PST
Created attachment 26562 [details] Diff form last version of the patch: I noticed a bad indentation in one place and fixed it.
Alexey Proskuryakov
Comment 4 2009-01-09 01:41:03 PST
Comment on attachment 26562 [details] Diff form last version of the patch: I noticed a bad indentation in one place and fixed it. r=me A general comment, not for this patch: the prevalent style is to have "using namespace std", and avoid explicit namespace qualifiers.
Alexey Proskuryakov
Comment 5 2009-01-09 01:42:42 PST
Committed revision 39740.
Note You need to log in before you can comment on or make changes to this bug.