Bug 231955
| Summary: | Improve intrinsic aspect ratio detection | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bfulgham, rbuis, simon.fraser, webkit-bug-importer, zalan |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=231952 | ||
Sergio Villar Senin
The current implementation of RenderObject::hasIntrinsicAspectRatio() performs a very basic test to check whether a renderer has intrinsic aspect ratio. It does not cover however the cases of many SVGs which have intrinsic aspect ratios but no intrinsic dimensions.
We should consider make it virtual returning false by default. Then RenderReplaced will overwrite it with the current implementation plus a call to
computeIntrinsicRatioInformation() that will tell us for sure whether or not we have an intrinsic aspect ratio.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/84664281>