Bug 231896

Summary: Web Inspector: Remove Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController.js.orig
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Web InspectorAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, drousso, ews-watchlist, inspector-bugzilla-changes, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Differences between files (do not commit)
none
Patch v1 none

Description David Kilzer (:ddkilzer) 2021-10-18 08:53:48 PDT
Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController.js.orig was committed in r283857 and modified in r283859, but still has some differences from WebInspectorExtensionController.js.

It seems like it could be removed, but someone with knowledge of this source should check to see that it's okay to remove it without any further changes to WebInspectorExtensionController.js.

Found while running `find Source -name \*.orig` to look for local backup files left by patch(1) command.
Comment 1 David Kilzer (:ddkilzer) 2021-10-18 08:54:42 PDT
Created attachment 441609 [details]
Differences between files (do not commit)
Comment 2 David Kilzer (:ddkilzer) 2021-10-18 08:55:17 PDT
(In reply to David Kilzer (:ddkilzer) from comment #1)
> Created attachment 441609 [details]
> Differences between files (do not commit)

$ diff -u Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController.js Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController.js.orig > bug-231896-WebInspectorExtensionController.js.orig.diff
Comment 3 David Kilzer (:ddkilzer) 2021-10-18 08:56:49 PDT
Created attachment 441610 [details]
Patch v1
Comment 4 EWS 2021-10-18 18:43:09 PDT
Committed r284422 (243190@main): <https://commits.webkit.org/243190@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441610 [details].
Comment 5 Radar WebKit Bug Importer 2021-10-18 18:44:18 PDT
<rdar://problem/84397260>