RESOLVED FIXED 231896
Web Inspector: Remove Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController.js.orig 
https://bugs.webkit.org/show_bug.cgi?id=231896
Summary Web Inspector: Remove Source/WebInspectorUI/UserInterface/Controllers/WebInsp...
David Kilzer (:ddkilzer)
Reported 2021-10-18 08:53:48 PDT
Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController.js.orig was committed in r283857 and modified in r283859, but still has some differences from WebInspectorExtensionController.js. It seems like it could be removed, but someone with knowledge of this source should check to see that it's okay to remove it without any further changes to WebInspectorExtensionController.js. Found while running `find Source -name \*.orig` to look for local backup files left by patch(1) command.
Attachments
Differences between files (do not commit) (5.72 KB, patch)
2021-10-18 08:54 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
Patch v1 (10.77 KB, patch)
2021-10-18 08:56 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2021-10-18 08:54:42 PDT
Created attachment 441609 [details] Differences between files (do not commit)
David Kilzer (:ddkilzer)
Comment 2 2021-10-18 08:55:17 PDT
(In reply to David Kilzer (:ddkilzer) from comment #1) > Created attachment 441609 [details] > Differences between files (do not commit) $ diff -u Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController.js Source/WebInspectorUI/UserInterface/Controllers/WebInspectorExtensionController.js.orig > bug-231896-WebInspectorExtensionController.js.orig.diff
David Kilzer (:ddkilzer)
Comment 3 2021-10-18 08:56:49 PDT
Created attachment 441610 [details] Patch v1
EWS
Comment 4 2021-10-18 18:43:09 PDT
Committed r284422 (243190@main): <https://commits.webkit.org/243190@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441610 [details].
Radar WebKit Bug Importer
Comment 5 2021-10-18 18:44:18 PDT
<rdar://problem/84397260>
Note You need to log in before you can comment on or make changes to this bug.