Bug 23188 – Need to cleanup all the names of state functions in AnimationBase

• Component: CSS
• Status: RESOLVED FIXED

[Chris Marrin]

There are many functions in AnimationBase (like isNew() and postactive()) which tell you which state or states the state machine is in. But they are really confusing, both in how they are named and what they actually mean. These should all be cleaned up

[Simon Fraser (smfr)]

Also willNeedService() needs a better name.

[Simon Fraser (smfr)]

Also:

In Animation:

    bool direction() const { return m_direction; }
This needs to have an enum.
    int iterationCount() const { return m_iterationCount; }
This needs a constant for the magic "-1" value.

[Simon Fraser (smfr)]

*** Bug 23513 has been marked as a duplicate of this bug. ***

[Simon Fraser (smfr)]

Created attachment 27617 [details]
Patch to clean up Animation

[Simon Fraser (smfr)]

Created attachment 27620 [details]
Same patch with no license changes.

[Dave Hyatt]

Comment on attachment 27620 [details]
Same patch with no license changes.

r=me

[Simon Fraser (smfr)]

Comment on attachment 27620 [details]
Same patch with no license changes.

Landed:
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	M	WebCore/css/CSSComputedStyleDeclaration.cpp
	M	WebCore/platform/animation/Animation.cpp
	M	WebCore/platform/animation/Animation.h
	M	WebCore/platform/graphics/mac/GraphicsLayerCA.mm
Committed r40923

[Brent Fulgham]

Closing bug as it has been committed to the archive.

[Simon Fraser (smfr)]

There's more cleanup to do (specifically, willGetService()).

[Eric Seidel (no email)]

Comment on attachment 27620 [details]
Same patch with no license changes.

Historically we've tried for one-bug-per-change.  But if you'd like to leave this open, we should at least clear the review flag to remove it from the commit queue.  (Eventually we should just fix the commit queue query).

[Alexis Menard (darktears)]

I think all the cleanup landed. I can't find any trace of the old confusing names.