Bug 231865

Summary: Share stacking context code between RenderLayer & StyleAdjuster
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: Layout and RenderingAssignee: Tim Nguyen (:ntim) <ntim>
Status: NEW ---    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch simon.fraser: review-, ews-feeder: commit-queue-

Description Tim Nguyen (:ntim) 2021-10-16 11:21:34 PDT 
Situations where CSS should create stacking contexts are written in 3 different places: RenderLayer, StyleAdjuster, WillChangeData

Let's introduce a single method in RenderStyle that RenderLayer & StyleAdjuster can both consult.
Comment 1 Radar WebKit Bug Importer 2021-10-16 11:21:44 PDT 
<rdar://problem/84334466>
Comment 2 Tim Nguyen (:ntim) 2021-10-16 11:31:07 PDT 
Created attachment 441497 [details]
Patch
Comment 3 Tim Nguyen (:ntim) 2021-10-16 11:42:06 PDT 
Created attachment 441498 [details]
Patch
Comment 4 Simon Fraser (smfr) 2021-10-16 11:46:34 PDT 
Comment on attachment 441498 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441498&action=review

> Source/WebCore/rendering/style/RenderStyle.cpp:2790
> +        || hasTransformRelatedProperty()

I think this is a behavior change because renderer.hasTransformRelatedProperty() is not always equivalent to style.hasTransformRelatedProperty() since transforms don't apply to non-atomic lines.
Comment 5 Tim Nguyen (:ntim) 2021-10-16 12:11:33 PDT 
Created attachment 441499 [details]
Patch
Comment 6 Simon Fraser (smfr) 2021-10-16 15:52:44 PDT 
Comment on attachment 441499 [details]
Patch

Test failures show this isn't right.