Bug 231865

Summary: Share stacking context code between RenderLayer & StyleAdjuster
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: Layout and RenderingAssignee: Tim Nguyen (:ntim) <ntim>
Status: NEW    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch simon.fraser: review-, ews-feeder: commit-queue-

Tim Nguyen (:ntim)
Reported 2021-10-16 11:21:34 PDT
Situations where CSS should create stacking contexts are written in 3 different places: RenderLayer, StyleAdjuster, WillChangeData Let's introduce a single method in RenderStyle that RenderLayer & StyleAdjuster can both consult.
Attachments
Patch (9.96 KB, patch)
2021-10-16 11:31 PDT, Tim Nguyen (:ntim) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (9.96 KB, patch)
2021-10-16 11:42 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (10.14 KB, patch)
2021-10-16 12:11 PDT, Tim Nguyen (:ntim) 		simon.fraser: review-
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-16 11:21:44 PDT
<rdar://problem/84334466>
Tim Nguyen (:ntim)
Comment 2 2021-10-16 11:31:07 PDT
Created attachment 441497 [details] Patch
Tim Nguyen (:ntim)
Comment 3 2021-10-16 11:42:06 PDT
Created attachment 441498 [details] Patch
Simon Fraser (smfr)
Comment 4 2021-10-16 11:46:34 PDT
Comment on attachment 441498 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441498&action=review > Source/WebCore/rendering/style/RenderStyle.cpp:2790 > + || hasTransformRelatedProperty() I think this is a behavior change because renderer.hasTransformRelatedProperty() is not always equivalent to style.hasTransformRelatedProperty() since transforms don't apply to non-atomic lines.
Tim Nguyen (:ntim)
Comment 5 2021-10-16 12:11:33 PDT
Created attachment 441499 [details] Patch
Simon Fraser (smfr)
Comment 6 2021-10-16 15:52:44 PDT
Comment on attachment 441499 [details] Patch Test failures show this isn't right.
Note You need to log in before you can comment on or make changes to this bug.