Bug 231846

Summary: Integrate "Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick" from Google ANGLE
Product: WebKit Reporter: Kyle Piddington <kpiddington>
Component: New BugsAssignee: Kyle Piddington <kpiddington>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, gman, kbr, kkinnunen, kondapallykalyan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kyle Piddington
Reported 2021-10-15 17:16:23 PDT
Integrate "Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick" from Google ANGLE
Attachments
Patch (2.18 KB, patch)
2021-10-15 17:17 PDT, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Patch (2.23 KB, patch)
2021-10-15 17:18 PDT, Kyle Piddington 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kyle Piddington
Comment 1 2021-10-15 17:17:35 PDT
Created attachment 441459 [details] Patch
Kyle Piddington
Comment 2 2021-10-15 17:18:49 PDT
Created attachment 441460 [details] Patch
EWS Watchlist
Comment 3 2021-10-15 17:20:06 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Kenneth Russell
Comment 4 2021-10-15 17:32:58 PDT
Comment on attachment 441460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441460&action=review > Source/ThirdParty/ANGLE/ChangeLog:3 > + Integrate "Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick" from Google ANGLE Is this really a cherry-pick and merge of: Metal Direct: TinyDepthStencilWorkaroundTest.DepthTexturesStick https://chromium-review.googlesource.com/3169438 ? It looks different - the other one inserted a second entry in the attributeBindings map. Also, could you reference the code review above either in the commit message or the bug?
Radar WebKit Bug Importer
Comment 5 2021-10-22 17:17:17 PDT
<rdar://problem/84569850>
Kyle Piddington
Comment 6 2022-01-12 10:46:36 PST
Handled with part of previous ANGLE roll.
Note You need to log in before you can comment on or make changes to this bug.