| Summary: | [libpas] Enable libpas on macOS | ||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||||||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||||||||||||||||||||||
| Severity: | Normal | CC: | annulen, benjamin, cdumez, cmarcelo, commit-queue, eric.carlson, ews-watchlist, fpizlo, glenn, gyuyoung.kim, jer.noble, philipj, ryuan.choi, saam, sergio, webkit-bug-importer | ||||||||||||||||||||||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||||||||||||||||||||
| Bug Depends on: | 231859, 232011 | ||||||||||||||||||||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||
|
Description
Yusuke Suzuki
2021-10-15 10:30:08 PDT
Created attachment 441399 [details]
Patch
Comment on attachment 441399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441399&action=review r=me > Source/bmalloc/ChangeLog:12 > + 1. Speedometer2 is 2.1% improved on low-end macOS (MBA8,2) and 1.7% improved on high-end macOS (MBP14,1). nice! mac-debug-wk1 is getting stuck, and after 11 hours, still it is not scheduled. I'll land it for now. Committed r284305 (243103@main): <https://commits.webkit.org/243103@main> Re-opened since this is blocked by bug 231859 Created attachment 441482 [details]
Patch
Created attachment 441517 [details]
Patch
Created attachment 441521 [details]
Patch
Created attachment 441522 [details]
Patch
Created attachment 441523 [details]
Patch
Created attachment 441524 [details]
Patch
Created attachment 441525 [details]
Patch
Created attachment 441526 [details]
Patch
Created attachment 441527 [details]
Patch
Created attachment 441528 [details]
Patch
Created attachment 441542 [details]
Patch
Created attachment 441567 [details]
Patch
Created attachment 441637 [details]
Patch
Created attachment 441662 [details]
Patch
Comment on attachment 441662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441662&action=review > Source/bmalloc/libpas/src/libpas/pas_utils_prefix.h:-50 > -#ifdef __OPTIMIZE__ > #define __PAS_ALWAYS_INLINE_BUT_NOT_INLINE __attribute__((__always_inline__)) > -#else > -#define __PAS_ALWAYS_INLINE_BUT_NOT_INLINE > -#endif > - Is this change still necessary? If it's not, then I'd kill it, since in those cases where you actually have to debug libpas (and build it in debug mode), you'll want the inlining turned off. Created attachment 441767 [details]
Patch
Try removing always-inline change
Created attachment 441768 [details]
Patch
Try removing always-inline change
Created attachment 441850 [details]
Patch
Try WebAudio test
OK! I found a bug in WebAudio code :) I'll create a patch in a separate bug. (In reply to Yusuke Suzuki from comment #25) > OK! I found a bug in WebAudio code :) > I'll create a patch in a separate bug. The failure is WebAudio bug. https://bugs.webkit.org/show_bug.cgi?id=232011 Created attachment 441901 [details]
Patch
Patch for landing
Committed r285407 (243964@main): <https://commits.webkit.org/243964@main> Committed r285415 (243972@main): <https://commits.webkit.org/243972@main> Committed r285416 (243973@main): <https://commits.webkit.org/243973@main> |