Bug 231815

Summary:

[libpas] Enable libpas on macOS

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, benjamin, cdumez, cmarcelo, commit-queue, eric.carlson, ews-watchlist, fpizlo, glenn, gyuyoung.kim, jer.noble, philipj, ryuan.choi, saam, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

231859, 232011

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none
Patch	ews-feeder: commit-queue-
Patch	none
Patch	none
Patch	none
Patch	none
Patch	fpizlo: review+
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-

Yusuke Suzuki

Reported 2021-10-15 10:30:08 PDT

[libpas] Enable libpas on macOS

Attachments
Patch (1.50 KB, patch) 2021-10-15 10:31 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (1.43 KB, patch) 2021-10-16 01:14 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (2.17 KB, patch) 2021-10-16 22:09 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (86.53 KB, patch) 2021-10-17 02:16 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (86.46 KB, patch) 2021-10-17 02:23 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (93.02 KB, patch) 2021-10-17 02:46 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (93.46 KB, patch) 2021-10-17 02:49 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (93.73 KB, patch) 2021-10-17 02:51 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (93.30 KB, patch) 2021-10-17 02:54 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (92.00 KB, patch) 2021-10-17 03:09 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (92.00 KB, patch) 2021-10-17 03:12 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (92.55 KB, patch) 2021-10-17 11:57 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (92.59 KB, patch) 2021-10-18 01:12 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (91.05 KB, patch) 2021-10-18 13:35 PDT, Yusuke Suzuki	no flags	Details Formatted Diff Diff
Patch (51.10 KB, patch) 2021-10-18 17:18 PDT, Yusuke Suzuki	fpizlo: review+	Details Formatted Diff Diff
Patch (51.84 KB, patch) 2021-10-19 12:06 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (50.36 KB, patch) 2021-10-19 12:19 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (51.70 KB, patch) 2021-10-19 22:33 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (50.36 KB, patch) 2021-10-20 11:17 PDT, Yusuke Suzuki	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (17) View All Add attachment proposed patch, testcase, etc.

Yusuke Suzuki

Comment 1 2021-10-15 10:31:57 PDT

Created attachment 441399 [details] Patch

Saam Barati

Comment 2 2021-10-15 11:39:35 PDT

Comment on attachment 441399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441399&action=review r=me > Source/bmalloc/ChangeLog:12 > + 1. Speedometer2 is 2.1% improved on low-end macOS (MBA8,2) and 1.7% improved on high-end macOS (MBP14,1). nice!

Yusuke Suzuki

Comment 3 2021-10-15 21:35:51 PDT

mac-debug-wk1 is getting stuck, and after 11 hours, still it is not scheduled. I'll land it for now.

Yusuke Suzuki

Comment 4 2021-10-15 21:38:34 PDT

Committed r284305 (243103@main): <https://commits.webkit.org/243103@main>

Radar WebKit Bug Importer

Comment 5 2021-10-15 21:39:15 PDT

<rdar://problem/84326992>

WebKit Commit Bot

Comment 6 2021-10-16 00:56:20 PDT

Re-opened since this is blocked by bug 231859

Yusuke Suzuki

Comment 7 2021-10-16 01:14:13 PDT

Created attachment 441482 [details] Patch

Yusuke Suzuki

Comment 8 2021-10-16 22:09:18 PDT

Created attachment 441517 [details] Patch

Yusuke Suzuki

Comment 9 2021-10-17 02:16:26 PDT

Created attachment 441521 [details] Patch

Yusuke Suzuki

Comment 10 2021-10-17 02:23:44 PDT

Created attachment 441522 [details] Patch

Yusuke Suzuki

Comment 11 2021-10-17 02:46:32 PDT

Created attachment 441523 [details] Patch

Yusuke Suzuki

Comment 12 2021-10-17 02:49:03 PDT

Created attachment 441524 [details] Patch

Yusuke Suzuki

Comment 13 2021-10-17 02:51:14 PDT

Created attachment 441525 [details] Patch

Yusuke Suzuki

Comment 14 2021-10-17 02:54:59 PDT

Created attachment 441526 [details] Patch

Yusuke Suzuki

Comment 15 2021-10-17 03:09:20 PDT

Created attachment 441527 [details] Patch

Yusuke Suzuki

Comment 16 2021-10-17 03:12:08 PDT

Created attachment 441528 [details] Patch

Yusuke Suzuki

Comment 17 2021-10-17 11:57:11 PDT

Created attachment 441542 [details] Patch

Yusuke Suzuki

Comment 18 2021-10-18 01:12:49 PDT

Created attachment 441567 [details] Patch

Yusuke Suzuki

Comment 19 2021-10-18 13:35:27 PDT

Created attachment 441637 [details] Patch

Yusuke Suzuki

Comment 20 2021-10-18 17:18:15 PDT

Created attachment 441662 [details] Patch

Filip Pizlo

Comment 21 2021-10-19 10:42:34 PDT

Comment on attachment 441662 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441662&action=review > Source/bmalloc/libpas/src/libpas/pas_utils_prefix.h:-50 > -#ifdef __OPTIMIZE__ > #define __PAS_ALWAYS_INLINE_BUT_NOT_INLINE __attribute__((__always_inline__)) > -#else > -#define __PAS_ALWAYS_INLINE_BUT_NOT_INLINE > -#endif > - Is this change still necessary? If it's not, then I'd kill it, since in those cases where you actually have to debug libpas (and build it in debug mode), you'll want the inlining turned off.

Yusuke Suzuki

Comment 22 2021-10-19 12:06:21 PDT

Created attachment 441767 [details] Patch Try removing always-inline change

Yusuke Suzuki

Comment 23 2021-10-19 12:19:07 PDT

Created attachment 441768 [details] Patch Try removing always-inline change

Yusuke Suzuki

Comment 24 2021-10-19 22:33:20 PDT

Created attachment 441850 [details] Patch Try WebAudio test

Yusuke Suzuki

Comment 25 2021-10-20 05:32:40 PDT

OK! I found a bug in WebAudio code :) I'll create a patch in a separate bug.

Yusuke Suzuki

Comment 26 2021-10-20 05:56:42 PDT

(In reply to Yusuke Suzuki from comment #25) > OK! I found a bug in WebAudio code :) > I'll create a patch in a separate bug. The failure is WebAudio bug. https://bugs.webkit.org/show_bug.cgi?id=232011

Yusuke Suzuki

Comment 27 2021-10-20 11:17:28 PDT

Created attachment 441901 [details] Patch Patch for landing

Yusuke Suzuki

Comment 28 2021-11-08 09:07:30 PST

Committed r285407 (243964@main): <https://commits.webkit.org/243964@main>

Yusuke Suzuki

Comment 29 2021-11-08 10:52:46 PST

Committed r285415 (243972@main): <https://commits.webkit.org/243972@main>

Yusuke Suzuki

Comment 30 2021-11-08 11:01:10 PST

Committed r285416 (243973@main): <https://commits.webkit.org/243973@main>

Note You need to log in before you can comment on or make changes to this bug.