Bug 231804

Summary: Cocoa GraphicsContextGLOpenGL should not use WebGLLayer
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cmarcelo, dino, ews-watchlist, gyuyoung.kim, kbr, kkinnunen, kondapallykalyan, luiz, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 231009    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing
none
Patch for landing
ews-feeder: commit-queue-
Patch for landing
none
Patch for landing none

Kimmo Kinnunen
Reported 2021-10-15 05:57:41 PDT
Cocoa GraphicsContextGLOpenGL should not use WebGLLayer When in GPU Process, GraphicsContextGLOpenGL does not need WebGLLayer. Instead, GraphicsContextGLOpenGL should just use the "swap chain" directly, e.g. just hold the IOSurfaces for display buffer and drawing buffer.
Attachments
Patch (49.73 KB, patch)
2021-10-15 10:18 PDT, Kimmo Kinnunen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (50.10 KB, patch)
2021-10-15 10:54 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (50.86 KB, patch)
2021-10-16 03:28 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (50.83 KB, patch)
2021-10-17 03:24 PDT, Kimmo Kinnunen 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (50.86 KB, patch)
2021-10-17 04:01 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Patch for landing (52.33 KB, patch)
2021-10-18 00:44 PDT, Kimmo Kinnunen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Kimmo Kinnunen
Comment 1 2021-10-15 10:18:49 PDT
Created attachment 441396 [details] Patch
Kimmo Kinnunen
Comment 2 2021-10-15 10:54:05 PDT
Created attachment 441402 [details] Patch
Kimmo Kinnunen
Comment 3 2021-10-16 03:28:00 PDT
Created attachment 441484 [details] Patch for landing
Kimmo Kinnunen
Comment 4 2021-10-17 03:24:38 PDT
Created attachment 441529 [details] Patch for landing
Kimmo Kinnunen
Comment 5 2021-10-17 04:01:28 PDT
Created attachment 441531 [details] Patch for landing
Kimmo Kinnunen
Comment 6 2021-10-18 00:44:49 PDT
Created attachment 441565 [details] Patch for landing
EWS
Comment 7 2021-10-18 07:57:30 PDT
Committed r284371 (243156@main): <https://commits.webkit.org/243156@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441565 [details].
Radar WebKit Bug Importer
Comment 8 2021-10-18 07:58:41 PDT
<rdar://problem/84370716>
Note You need to log in before you can comment on or make changes to this bug.