Bug 23176

Summary: WebCore::Event::timeStamp() should be const
Product: WebKit Reporter: James Robinson <jamesr>
Component: WebKit APIAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Attachments:
Description Flags
Changes the accessor to be const
sam: review+
Changes the accessor to be const and adds name/bug url to ChangeLog mrowe: review+

James Robinson
Reported 2009-01-07 15:25:40 PST
WebCore::Event's timeStamp() is a trivial accessor and should be const so code with a const reference or pointer can query the field.
Attachments
Changes the accessor to be const (1015 bytes, patch)
2009-01-07 15:26 PST, James Robinson 		sam: review+
DetailsFormatted DiffDiff
Changes the accessor to be const and adds name/bug url to ChangeLog (1.08 KB, patch)
2009-01-07 15:45 PST, James Robinson 		mrowe: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2009-01-07 15:26:36 PST
Created attachment 26509 [details] Changes the accessor to be const
Sam Weinig
Comment 2 2009-01-07 15:32:40 PST
Comment on attachment 26509 [details] Changes the accessor to be const > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 39688) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,12 @@ > +2009-01-07 James Robinson <jamesr@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + WARNING: NO TEST CASES ADDED OR CHANGED Please add at least the name and url of the bug and short description of your change.
James Robinson
Comment 3 2009-01-07 15:45:02 PST
Created attachment 26510 [details] Changes the accessor to be const and adds name/bug url to ChangeLog
Pam Greene (IRC:pamg)
Comment 4 2009-01-08 16:30:57 PST
Landed in r39726.
Note You need to log in before you can comment on or make changes to this bug.