Bug 231756

Summary: AX: role="math" elements are no longer considered to have presentational children
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, darin, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Tyler Wilcock 2021-10-14 12:12:00 PDT 
In WAI-ARIA 1.1 (https://www.w3.org/TR/wai-aria-1.1/#math-0), role="math" elements were considered to have presentational children. This changed in WAI-ARIA 1.2 (https://www.w3.org/TR/wai-aria-1.2/#math).
Comment 1 Radar WebKit Bug Importer 2021-10-14 12:12:12 PDT 
<rdar://problem/84268174>
Comment 2 Tyler Wilcock 2021-10-14 12:18:29 PDT 
Created attachment 441252 [details]
Patch
Comment 3 Darin Adler 2021-10-14 12:34:39 PDT 
Comment on attachment 441252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441252&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:401
>  #if ENABLE(MATHML)
> -        return node()->isMathMLElement();
> +        return true;
>  #endif
>          return false;

Seems like this should use #else.

But also, is it really important to return false for this when building without MathML support?
Comment 4 Tyler Wilcock 2021-10-14 12:52:41 PDT 
Created attachment 441261 [details]
Patch
Comment 5 Tyler Wilcock 2021-10-14 12:54:04 PDT 
Created attachment 441263 [details]
Patch
Comment 6 Tyler Wilcock 2021-10-14 12:54:31 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 441252 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=441252&action=review
> 
> > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:401
> >  #if ENABLE(MATHML)
> > -        return node()->isMathMLElement();
> > +        return true;
> >  #endif
> >          return false;
> 
> Seems like this should use #else.
> 
> But also, is it really important to return false for this when building
> without MathML support?

No, it isn't. Submitted a patch with this changed.
Comment 7 EWS 2021-10-15 08:13:30 PDT 
Committed r284246 (243055@main): <https://commits.webkit.org/243055@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441263 [details].