Summary: | [iOS] Paint <datalist> indicator in RenderTheme | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Aditya Keerthi <akeerthi> | ||||||
Component: | New Bugs | Assignee: | Aditya Keerthi <akeerthi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, thorton, webkit-bug-importer, wenson_hsieh | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 231762 | ||||||||
Attachments: |
|
Description
Aditya Keerthi
2021-10-14 12:09:52 PDT
Created attachment 441253 [details]
Patch
Created attachment 441255 [details]
Patch
Comment on attachment 441255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441255&action=review > Source/WebCore/rendering/style/RenderStyle.h:1477 > + void setHasExplicitlyClearedContent(bool v) { m_nonInheritedFlags.hasExplicitlyClearedContent = v; } `v` is not my favorite name for a parameter (In reply to Tim Horton from comment #4) > Comment on attachment 441255 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=441255&action=review > > > Source/WebCore/rendering/style/RenderStyle.h:1477 > > + void setHasExplicitlyClearedContent(bool v) { m_nonInheritedFlags.hasExplicitlyClearedContent = v; } > > `v` is not my favorite name for a parameter I was just following the naming convention in the rest of this class :) (In reply to Aditya Keerthi from comment #5) > (In reply to Tim Horton from comment #4) > > Comment on attachment 441255 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=441255&action=review > > > > > Source/WebCore/rendering/style/RenderStyle.h:1477 > > > + void setHasExplicitlyClearedContent(bool v) { m_nonInheritedFlags.hasExplicitlyClearedContent = v; } > > > > `v` is not my favorite name for a parameter > > I was just following the naming convention in the rest of this class :) Ah, I thought that might be but I couldn't expand the context for some reason! Fine :D Committed r284225 (243034@main): <https://commits.webkit.org/243034@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441255 [details]. |