Bug 231755

Summary: [iOS] Paint <datalist> indicator in RenderTheme
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: New BugsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 231762    
Attachments:
Description Flags
Patch
none
Patch none

Aditya Keerthi
Reported 2021-10-14 12:09:52 PDT
...
Attachments
Patch (15.72 KB, patch)
2021-10-14 12:20 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (15.76 KB, patch)
2021-10-14 12:26 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2021-10-14 12:10:09 PDT
rdar://84261604
Aditya Keerthi
Comment 2 2021-10-14 12:20:12 PDT
Created attachment 441253 [details] Patch
Aditya Keerthi
Comment 3 2021-10-14 12:26:07 PDT
Created attachment 441255 [details] Patch
Tim Horton
Comment 4 2021-10-14 12:32:56 PDT
Comment on attachment 441255 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441255&action=review > Source/WebCore/rendering/style/RenderStyle.h:1477 > + void setHasExplicitlyClearedContent(bool v) { m_nonInheritedFlags.hasExplicitlyClearedContent = v; } `v` is not my favorite name for a parameter
Aditya Keerthi
Comment 5 2021-10-14 12:34:49 PDT
(In reply to Tim Horton from comment #4) > Comment on attachment 441255 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=441255&action=review > > > Source/WebCore/rendering/style/RenderStyle.h:1477 > > + void setHasExplicitlyClearedContent(bool v) { m_nonInheritedFlags.hasExplicitlyClearedContent = v; } > > `v` is not my favorite name for a parameter I was just following the naming convention in the rest of this class :)
Tim Horton
Comment 6 2021-10-14 12:45:27 PDT
(In reply to Aditya Keerthi from comment #5) > (In reply to Tim Horton from comment #4) > > Comment on attachment 441255 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=441255&action=review > > > > > Source/WebCore/rendering/style/RenderStyle.h:1477 > > > + void setHasExplicitlyClearedContent(bool v) { m_nonInheritedFlags.hasExplicitlyClearedContent = v; } > > > > `v` is not my favorite name for a parameter > > I was just following the naming convention in the rest of this class :) Ah, I thought that might be but I couldn't expand the context for some reason! Fine :D
EWS
Comment 7 2021-10-14 18:58:32 PDT
Committed r284225 (243034@main): <https://commits.webkit.org/243034@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441255 [details].
Note You need to log in before you can comment on or make changes to this bug.