Bug 231753

Summary: Service workers running on the main thread should use the main VM
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Service WorkersAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ggaren, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2021-10-14 11:26:31 PDT
Service workers running on the main thread should use the main VM. This makes life easier for injected bundle clients and there is no strong reason to use a separate VM since VMs are mainly used for thread safety / isolation.
Attachments
Patch (8.53 KB, patch)
2021-10-14 11:29 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (8.48 KB, patch)
2021-10-14 15:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-10-14 11:29:28 PDT
Created attachment 441247 [details] Patch
Geoffrey Garen
Comment 2 2021-10-14 11:38:56 PDT
Comment on attachment 441247 [details] Patch r=me
EWS
Comment 3 2021-10-14 15:19:31 PDT
Found 30 new test failures: fast/css-custom-paint/animate.html, fast/css-custom-paint/arguments.html, fast/css-custom-paint/constructor.html, fast/css-custom-paint/delay-repaint.html, fast/css-custom-paint/delay.html, fast/css-custom-paint/image.html, fast/css-custom-paint/leaks.html, fast/css-custom-paint/multiple-worklets-isolation.html, fast/css-custom-paint/multiple-worklets.html, http/tests/media/hls/video-cookie.html ...
Chris Dumez
Comment 4 2021-10-14 15:40:49 PDT
Created attachment 441295 [details] Patch
EWS
Comment 5 2021-10-14 19:02:21 PDT
Committed r284226 (243035@main): <https://commits.webkit.org/243035@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441295 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-14 19:03:20 PDT
<rdar://problem/84285075>
Note You need to log in before you can comment on or make changes to this bug.