Bug 231753 - Service workers running on the main thread should use the main VM
Summary: Service workers running on the main thread should use the main VM
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-10-14 11:26 PDT by Chris Dumez
Modified: 2021-10-14 19:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (8.53 KB, patch)
2021-10-14 11:29 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (8.48 KB, patch)
2021-10-14 15:40 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-10-14 11:26:31 PDT 
Service workers running on the main thread should use the main VM. This makes life easier for injected bundle clients and there is no strong reason to use a separate VM since VMs are mainly used for thread safety / isolation.
Comment 1 Chris Dumez 2021-10-14 11:29:28 PDT 
Created attachment 441247 [details]
Patch
Comment 2 Geoffrey Garen 2021-10-14 11:38:56 PDT 
Comment on attachment 441247 [details]
Patch

r=me
Comment 3 EWS 2021-10-14 15:19:31 PDT 
Found 30 new test failures: fast/css-custom-paint/animate.html, fast/css-custom-paint/arguments.html, fast/css-custom-paint/constructor.html, fast/css-custom-paint/delay-repaint.html, fast/css-custom-paint/delay.html, fast/css-custom-paint/image.html, fast/css-custom-paint/leaks.html, fast/css-custom-paint/multiple-worklets-isolation.html, fast/css-custom-paint/multiple-worklets.html, http/tests/media/hls/video-cookie.html ...
Comment 4 Chris Dumez 2021-10-14 15:40:49 PDT 
Created attachment 441295 [details]
Patch
Comment 5 EWS 2021-10-14 19:02:21 PDT 
Committed r284226 (243035@main): <https://commits.webkit.org/243035@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441295 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-14 19:03:20 PDT 
<rdar://problem/84285075>