Bug 231744

Summary: Remove Variant.h
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, alecflett, andresg_22, annulen, apinheiro, beidson, benjamin, calvaris, cdumez, cfleizach, cgarcia, changseok, cmarcelo, darin, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, galpeter, glenn, gyuyoung.kim, hi, hta, jamesr, jcraig, jdiggs, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, mmaxfield, msaboff, pangle, philipj, ryuan.choi, saam, samuel_white, sergio, tommyw, tonikitoo, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2021-10-14 09:00:40 PDT
Remove Variant.h
Attachments
Patch (91.00 KB, patch)
2021-10-14 09:01 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (85.31 KB, patch)
2021-10-14 11:30 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-10-14 09:01:38 PDT
Created attachment 441224 [details] Patch
Alex Christensen
Comment 2 2021-10-14 11:30:28 PDT
Created attachment 441248 [details] Patch
Darin Adler
Comment 3 2021-10-14 12:31:54 PDT
Comment on attachment 441248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441248&action=review I’d be surprised if there aren’t at least some cases where we can just do without the include of <variant>, especially since including <wtf/StdLibExtras.h> will now pull it in > Source/WTF/wtf/StdLibExtras.h:32 > +#include <variant> Too bad there’s no way to dodge this. I wonder what effect it has on build times; what that tool Jer’s been using says about it. In the future, we might want to break up StdLibExtras.h into multiple headers if it’s hurting build times.
EWS
Comment 4 2021-10-14 16:30:18 PDT
Committed r284213 (243023@main): <https://commits.webkit.org/243023@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441248 [details].
Radar WebKit Bug Importer
Comment 5 2021-10-14 16:31:18 PDT
<rdar://problem/84280034>
Note You need to log in before you can comment on or make changes to this bug.