| Summary: | Remove Variant.h | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aboxhall, alecflett, andresg_22, annulen, apinheiro, beidson, benjamin, calvaris, cdumez, cfleizach, cgarcia, changseok, cmarcelo, darin, dmazzoni, eric.carlson, esprehn+autocc, ews-watchlist, fred.wang, galpeter, glenn, gyuyoung.kim, hi, hta, jamesr, jcraig, jdiggs, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, luiz, macpherson, mark.lam, menard, mifenton, mmaxfield, msaboff, pangle, philipj, ryuan.choi, saam, samuel_white, sergio, tommyw, tonikitoo, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2021-10-14 09:00:40 PDT
Created attachment 441224 [details]
Patch
Created attachment 441248 [details]
Patch
Comment on attachment 441248 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441248&action=review I’d be surprised if there aren’t at least some cases where we can just do without the include of <variant>, especially since including <wtf/StdLibExtras.h> will now pull it in > Source/WTF/wtf/StdLibExtras.h:32 > +#include <variant> Too bad there’s no way to dodge this. I wonder what effect it has on build times; what that tool Jer’s been using says about it. In the future, we might want to break up StdLibExtras.h into multiple headers if it’s hurting build times. Committed r284213 (243023@main): <https://commits.webkit.org/243023@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441248 [details]. |