Bug 231723

Summary: Further adjust style of alternate form control design
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, changseok, dino, esprehn+autocc, ews-watchlist, glenn, graouts, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Tim Horton
Reported 2021-10-14 00:05:36 PDT
Further adjust style of alternate form control design
Attachments
Patch (7.45 KB, patch)
2021-10-14 00:07 PDT, Tim Horton 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (7.49 KB, patch)
2021-10-14 00:14 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2021-10-14 00:07:31 PDT
Created attachment 441187 [details] Patch
Tim Horton
Comment 2 2021-10-14 00:08:01 PDT
<rdar://problem/84227020>
Tim Horton
Comment 3 2021-10-14 00:14:58 PDT
Created attachment 441188 [details] Patch
Dean Jackson
Comment 4 2021-10-14 10:29:35 PDT
Comment on attachment 441188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441188&action=review > Source/WebCore/css/parser/CSSParserContext.cpp:51 > + individualTransformPropertiesEnabled = true; We should make this the default in a separate patch. We've shipped it for a release or two now.
Tim Horton
Comment 5 2021-10-14 10:44:12 PDT
Comment on attachment 441188 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441188&action=review >> Source/WebCore/css/parser/CSSParserContext.cpp:51 >> + individualTransformPropertiesEnabled = true; > > We should make this the default in a separate patch. We've shipped it for a release or two now. It IS the default, the problem is that CSSParserContext doesn't care, *everything* defaults to false (thus the fixme). Possible that we should just delete the switch for individualTransformPropertiesEnabled though....
EWS
Comment 6 2021-10-14 10:58:25 PDT
Committed r284176 (242993@main): <https://commits.webkit.org/242993@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441188 [details].
Note You need to log in before you can comment on or make changes to this bug.