Bug 231695

Summary: Use a ScrollAnimation for rubber-banding
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, mrobinson, simon.fraser, thorton, tonikitoo, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Description Simon Fraser (smfr) 2021-10-13 13:04:35 PDT
Use a ScrollAnimation for rubber-banding
Comment 1 Simon Fraser (smfr) 2021-10-13 13:11:26 PDT
Created attachment 441124 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-10-13 13:16:05 PDT
Created attachment 441125 [details]
Patch
Comment 3 Tim Horton 2021-10-13 16:21:06 PDT
Comment on attachment 441125 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=441125&action=review

> Source/WebCore/platform/mac/ScrollingEffectsController.mm:449
> +    // Just like normal scrolling, prefer vertical rubberbanding

.
Comment 4 Simon Fraser (smfr) 2021-10-13 16:57:26 PDT
(In reply to Tim Horton from comment #3)
> > Source/WebCore/platform/mac/ScrollingEffectsController.mm:449
> > +    // Just like normal scrolling, prefer vertical rubberbanding
> 
> .

Next time :)
Comment 5 EWS 2021-10-13 17:18:08 PDT
Committed r284136 (242956@main): <https://commits.webkit.org/242956@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441125 [details].
Comment 6 Radar WebKit Bug Importer 2021-10-13 17:19:45 PDT
<rdar://problem/84224762>