Bug 231695

Summary: Use a ScrollAnimation for rubber-banding
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: ScrollingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, ews-watchlist, fred.wang, jamesr, luiz, mrobinson, simon.fraser, thorton, tonikitoo, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Simon Fraser (smfr)
Reported 2021-10-13 13:04:35 PDT
Use a ScrollAnimation for rubber-banding
Attachments
Patch (35.15 KB, patch)
2021-10-13 13:11 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (35.17 KB, patch)
2021-10-13 13:16 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-10-13 13:11:26 PDT
Created attachment 441124 [details] Patch
Simon Fraser (smfr)
Comment 2 2021-10-13 13:16:05 PDT
Created attachment 441125 [details] Patch
Tim Horton
Comment 3 2021-10-13 16:21:06 PDT
Comment on attachment 441125 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=441125&action=review > Source/WebCore/platform/mac/ScrollingEffectsController.mm:449 > + // Just like normal scrolling, prefer vertical rubberbanding .
Simon Fraser (smfr)
Comment 4 2021-10-13 16:57:26 PDT
(In reply to Tim Horton from comment #3) > > Source/WebCore/platform/mac/ScrollingEffectsController.mm:449 > > + // Just like normal scrolling, prefer vertical rubberbanding > > . Next time :)
EWS
Comment 5 2021-10-13 17:18:08 PDT
Committed r284136 (242956@main): <https://commits.webkit.org/242956@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441125 [details].
Radar WebKit Bug Importer
Comment 6 2021-10-13 17:19:45 PDT
<rdar://problem/84224762>
Note You need to log in before you can comment on or make changes to this bug.