Bug 231644

Summary: [css-values-4] viewport units should be floats
Product: WebKit Reporter: Devin Rousso <hi>
Component: CSSAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, emilio, esprehn+autocc, ews-watchlist, glenn, hi, kondapallykalyan, pdr, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 219287    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2021-10-12 16:38:20 PDT
views can be fractional pixels wide
Attachments
Patch (32.97 KB, patch)
2021-10-21 14:48 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (33.81 KB, patch)
2021-11-04 20:40 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-12 16:47:13 PDT
<rdar://problem/84172685>
Devin Rousso
Comment 2 2021-10-21 14:48:14 PDT
Created attachment 442065 [details] Patch
Devin Rousso
Comment 3 2021-10-21 14:50:45 PDT
Comment on attachment 442065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442065&action=review > Source/WebCore/page/FrameView.cpp:-5640 > - // Use the large size if no override is given since it's considered the default size. > - // if (m_largeViewportSizeOverride) { I accidentally left this in when I was working on fixing EWS test failures for <https://webkit.org/b/219287> 😅
Tim Horton
Comment 4 2021-11-04 13:55:09 PDT
Comment on attachment 442065 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=442065&action=review > Source/WebCore/ChangeLog:9 > + Views can be fractional pixels wide. We should not round, especially since viewport units >Views can be fractional pixels wide. Technically true but many other parts of WebKit do not correctly support even fractional *points* let alone fractional pixels. (Though I think you meant points anyway?). Still, no harm in this change.
Devin Rousso
Comment 5 2021-11-04 20:40:22 PDT
Created attachment 443373 [details] Patch
EWS
Comment 6 2021-11-05 10:43:40 PDT
Committed r285345 (243906@main): <https://commits.webkit.org/243906@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443373 [details].
Note You need to log in before you can comment on or make changes to this bug.