Bug 231599

Summary: [PlayStation] Enable RemoteInspector by default
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: PlatformAssignee: Basuke Suzuki <Basuke.Suzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, Basuke.Suzuki, ews-watchlist, gyuyoung.kim, Hironori.Fujii, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
PATCH
Hironori.Fujii: review+
PATCH
ews-feeder: commit-queue-
PATCH none

Description Basuke Suzuki 2021-10-12 11:21:37 PDT
It is treated as experimental feature right now. We need this in any case.
Comment 1 Basuke Suzuki 2021-10-12 11:26:03 PDT
Created attachment 440961 [details]
PATCH
Comment 2 Fujii Hironori 2021-10-12 12:44:59 PDT
Comment on attachment 440961 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=440961&action=review

> ChangeLog:8
> +        It is treated as experimental feature right now but we depends on this in various situation.

I think most WebKit developers are using present tense and the word "now" to describe the behavior of after the patch applied.
Comment 3 Basuke Suzuki 2021-10-12 14:12:03 PDT
Created attachment 440978 [details]
PATCH

Thanks. I've changed the sentence with your advice.
Comment 4 EWS 2021-10-12 14:13:10 PDT
Hironori Fujii found in /Volumes/Data/worker/Commit-Queue/build/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 5 Fujii Hironori 2021-10-12 14:15:12 PDT
(In reply to EWS from comment #4)
> Hironori Fujii found in /Volumes/Data/worker/Commit-Queue/build/ChangeLog
> does not appear to be a valid reviewer according to contributors.json.
> /Volumes/Data/worker/Commit-Queue/build/ChangeLog neither lists a valid
> reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case
> insensitive).

😁 I'm using my filmily name first.
Comment 6 Basuke Suzuki 2021-10-12 14:50:42 PDT
Created attachment 440987 [details]
PATCH

OMG
Comment 7 EWS 2021-10-12 17:19:04 PDT
Committed r284065 (242894@main): <https://commits.webkit.org/242894@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 440987 [details].
Comment 8 Radar WebKit Bug Importer 2021-10-12 17:20:21 PDT
<rdar://problem/84174098>