Bug 231582

Summary: Use STL instead of WTF::get_if, WTF::Monostate, WTF::visit, and WTF::holds_alternative
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, benjamin, berto, calvaris, cdumez, cgarcia, changseok, cmarcelo, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, galpeter, glenn, gustavo, gyuyoung.kim, hi, hta, jer.noble, jiewen_tan, joepeck, jsbell, kangil.han, keith_miller, kondapallykalyan, macpherson, mark.lam, menard, mifenton, mmaxfield, msaboff, pangle, pdr, philipj, pnormand, saam, sergio, tommyw, tzagallo, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2021-10-12 08:59:30 PDT
Use STL instead of WTF::get_if, WTF::Monostate, WTF::visit, and WTF::holds_alternative
Attachments
Patch (165.86 KB, patch)
2021-10-12 09:00 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-10-12 09:00:14 PDT
Created attachment 440942 [details] Patch
Darin Adler
Comment 2 2021-10-12 09:04:26 PDT
Comment on attachment 440942 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440942&action=review r=me assuming compile succeeds (which I assume it will since this was done with global replace, I hope) > Source/JavaScriptCore/ChangeLog:3 > + Use STL instead of WTF::get_if, WTF::Monostate, WTF::visit, and WTF::holds_alternative Pedantic terminology nitpick: The term "STL" is a bit archaic and I don’t think it applies here; you just mean the C++ standard library.
EWS
Comment 3 2021-10-12 13:43:58 PDT
Committed r284016 (242853@main): <https://commits.webkit.org/242853@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 440942 [details].
Radar WebKit Bug Importer
Comment 4 2021-10-12 13:45:19 PDT
<rdar://problem/84164480>
Note You need to log in before you can comment on or make changes to this bug.