Bug 231577

Summary: [webkitscmpy] List reviewers for pull-request
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jonathan Bedard
Reported 2021-10-12 07:40:19 PDT
We need to be able to list the set of reviewers who are involved in a pull-request. In particular, we need to be able to list the set of reviewers who have approved or are blocking a particular pull-request.
Attachments
Patch (24.41 KB, patch)
2021-10-12 07:48 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (24.45 KB, patch)
2021-10-13 08:11 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (25.79 KB, patch)
2021-10-13 13:51 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-10-12 07:40:45 PDT
<rdar://problem/84146807>
Jonathan Bedard
Comment 2 2021-10-12 07:48:45 PDT
Created attachment 440931 [details] Patch
Jonathan Bedard
Comment 3 2021-10-12 07:49:08 PDT
Pull-request: https://github.com/WebKit/WebKit/pull/14
dewei_zhu
Comment 4 2021-10-13 00:04:50 PDT
Comment on attachment 440931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=440931&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:86 > + elif not opened: This seems a bit awkward. Because if `opened=1` it will slip through both condition check. Maybe we should `assert opened in [True, False, None]` at the beginning? Another way is to use enum.Flag (new in python3.6, https://docs.python.org/3/library/enum.html) which supports bitwise operation.
Jonathan Bedard
Comment 5 2021-10-13 08:11:43 PDT
Created attachment 441079 [details] Patch
dewei_zhu
Comment 6 2021-10-13 12:46:17 PDT
Comment on attachment 441079 [details] Patch r=me
Jonathan Bedard
Comment 7 2021-10-13 13:51:06 PDT
Created attachment 441131 [details] Patch for landing
EWS
Comment 8 2021-10-13 15:09:50 PDT
Committed r284128 (242948@main): <https://commits.webkit.org/242948@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 441131 [details].
Note You need to log in before you can comment on or make changes to this bug.