[webkitscmpy] List reviewers for pull-request

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Jonathan Bedard]

We need to be able to list the set of reviewers who are involved in a pull-request. In particular, we need to be able to list the set of reviewers who have approved or are blocking a particular pull-request.

[Radar WebKit Bug Importer]

<rdar://problem/84146807>

[Jonathan Bedard]

Created attachment 440931 [details]
Patch

[Jonathan Bedard]

Pull-request: https://github.com/WebKit/WebKit/pull/14

Comment on attachment 440931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=440931&action=review

> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/bitbucket.py:86
> +            elif not opened:

This seems a bit awkward. Because if `opened=1` it will slip through both condition check. Maybe we should `assert opened in [True, False, None]` at the beginning?
Another way is to use enum.Flag (new in python3.6, https://docs.python.org/3/library/enum.html) which supports bitwise operation.

[Jonathan Bedard]

Created attachment 441079 [details]
Patch

Comment on attachment 441079 [details]
Patch

r=me

[Jonathan Bedard]

Created attachment 441131 [details]
Patch for landing

[EWS]

Committed r284128 (242948@main): <https://commits.webkit.org/242948@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 441131 [details].